-
Notifications
You must be signed in to change notification settings - Fork 3
Cleaned up Serialization code. #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhenrongliew
wants to merge
30
commits into
main
Choose a base branch
from
khwu/fix_serialization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct during deserialization. Added tests that "run" the deserialized method
…hanges in Deserializer initialization.
…ects. Let object serialize themselves
… All attributes wrapped as kind "attribute" in SerializationUnit. deserializer check if attribute is in DialectGroup
…o use basic encoding
…ling generic_deserialize.
Co-authored-by: Kai-Hsin Wu <[email protected]>
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
kaihsin
reviewed
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comment
kaihsin
approved these changes
Oct 14, 2025
…s, then call update_backedges
…ter's dialect group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked with @kaihsin
Replaced custom serialization methods with standardized construction of
SerializationUnit
objects.Keep handling Python builtins and IR objects in Serializer & Deserializer class.
Added runtime checks for supported serializable types for Python attributes and literals.
Cleaned up the
serialization/__init__.py
file.Added new entry point for
encode
anddecode
methods toDialectGroup
for program serialization and deserialization.