Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove module config links from Hotel Reservation System > Settings page #357

Merged
merged 1 commit into from
May 5, 2022

Conversation

abhishek-webkul
Copy link
Contributor

Removed following options from Hotel Reservation System > Settings page. These modules can now be configured from Modules and Services page.

  1. Hotel Reviews
  2. Footer Payment Block
  3. Custom Navigation Link

@wdammak
Copy link
Contributor

wdammak commented Apr 21, 2022

Why/utility?
The goal?

@abhishek-webkul
Copy link
Contributor Author

Why/utility? The goal?

In the next version, configurations of modules will be accessible from Modules and Services page. So we have removed them from Hotel reservation system > Settings page.

@wdammak
Copy link
Contributor

wdammak commented Apr 28, 2022

Grouping all the application parameters in the main module is more advanced but less practical in terms of maintenance. Well it's a choice to make, it's up to you to judge better as for me I would have liked to keep the old method.
Thank you for your feedack

@rohit053 rohit053 merged commit 6719a6a into Qloapps:develop May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants