-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to ESM #102
base: master
Are you sure you want to change the base?
Move to ESM #102
Conversation
@Qix- any chance of a review? This would also support: https://github.com/Qix-/color/issues/256 |
I will add TypeScript declarations as well. |
This needs more changes to support tree shaking. I will handle this later. |
@Qix- Do you have some ideas for the tree shaking? I have two ideas, the first one is: import {rgb, keyword} from 'color-convert';
rgb.hsl(0, 0, 0);
rgb.hex(0, 0, 0);
keyword.rgb(0, 0, 0); Another idea is to make all convert functions to single one: import {rgbToHsl, rgbToHex, keywordToRgb} from 'color-convert';
rgbToHsl(0, 0, 0);
rgbToHex(0, 0, 0);
keywordToRgb(0, 0, 0); What do you think? |
I feel like a refactor for tree-shakability might be appropriate to have as a separate PR? Converting to ESM with the API "as-is" (this pr), and then updating for tree-shaking, potentially modifying the api in a breaking way, as a separate change. Thoughts? (that's, of course, assuming that the next major release waits for both PRs to land) |
Both are OK for me. That depends on @Qix-. |
Either way, appreciate all the work you've put in. Hopefully @Qix- gives it a look soon. |
@Qix- any chance on feedback here? This has been pending for almost a year |
could you release a separate package for the ESM version? |
Closes #57
Closes #103
Closes #104