Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ESM #102

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Move to ESM #102

wants to merge 5 commits into from

Conversation

LitoMore
Copy link

@LitoMore LitoMore commented Sep 11, 2022

Closes #57
Closes #103
Closes #104

@michaelfaith
Copy link

@Qix- any chance of a review? This would also support: https://github.com/Qix-/color/issues/256

@LitoMore LitoMore marked this pull request as draft June 4, 2023 22:55
@LitoMore
Copy link
Author

LitoMore commented Jun 4, 2023

I will add TypeScript declarations as well.

@LitoMore LitoMore marked this pull request as ready for review June 5, 2023 00:50
@LitoMore
Copy link
Author

LitoMore commented Jun 5, 2023

This needs more changes to support tree shaking. I will handle this later.

@LitoMore LitoMore marked this pull request as draft June 5, 2023 12:19
@LitoMore
Copy link
Author

LitoMore commented Jun 5, 2023

@Qix- Do you have some ideas for the tree shaking?

I have two ideas, the first one is:

import {rgb, keyword} from 'color-convert';

rgb.hsl(0, 0, 0);
rgb.hex(0, 0, 0);
keyword.rgb(0, 0, 0);

Another idea is to make all convert functions to single one:

import {rgbToHsl, rgbToHex, keywordToRgb} from 'color-convert';

rgbToHsl(0, 0, 0);
rgbToHex(0, 0, 0);
keywordToRgb(0, 0, 0);

What do you think?

@michaelfaith
Copy link

michaelfaith commented Jun 5, 2023

I feel like a refactor for tree-shakability might be appropriate to have as a separate PR? Converting to ESM with the API "as-is" (this pr), and then updating for tree-shaking, potentially modifying the api in a breaking way, as a separate change. Thoughts? (that's, of course, assuming that the next major release waits for both PRs to land)

@LitoMore
Copy link
Author

LitoMore commented Jun 5, 2023

Both are OK for me. That depends on @Qix-.

@michaelfaith
Copy link

Either way, appreciate all the work you've put in. Hopefully @Qix- gives it a look soon.

@michaelfaith
Copy link

@Qix- any chance on feedback here? This has been pending for almost a year

@fantasy0v0
Copy link

fantasy0v0 commented Jan 16, 2024

could you release a separate package for the ESM version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update module color-name version Convert to import/export definitions
4 participants