DNM: Test wheel builds with new cibuildwheel #186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit just triggers a build of the release wheels to verify that everythin still works with the new cibuildwheel version and python 3.9.
mtreinish
added a commit
to mtreinish/retworkx
that referenced
this pull request
Oct 29, 2020
In Qiskit#168 we added support for 3.9 which included the CI config to publish Python 3.9 wheels. However as was caught in Qiskit#186 it neglected to remove the Python 3.9 skip for the win32 wheel job. This commit corrects the oversight so when we push a release we build a Python 3.9 wheel for win32.
Member
Author
|
Everything seems to work (except for #187 which this caught), the s390x is failing because of typical travis flakiness. We should be good to release since all the jobs seem to work still and build 3.9 wheels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit just triggers a build of the release wheels to verify that
everythin still works with the new cibuildwheel version and python 3.9.