Add falqon algorithm to qiskit-terra#9624
Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
|
|
|
Thank you for your interest in contributing to Qiskit. It has however been decided that the algorithms are to be moved out of Qiskit (see #10406) and the plan is a new community repository that will contain these going forwards. As such I am going to close this PR as it stands. If you still have interest in pursuing this then might I suggest a community project in the ecosystem for this. See https://qiskit.org/ecosystem/ and follow/click the "Join the ecosystem" for more information on what that would entail. |
Summary
To add the Feedback-based quantum optimization (falqon) algorithm (arxiv).
Details and comments
I had to close the previous issue #8751 for some reason. I've implemented into the algorithm the
Estimatorprimitive and theMinimumEigensolverinterface. Now I have the following questions:a) should this main loop remain to be implemented inside the falqon class and handling of the intermediate results be left to a callback function implemented by users,
b) or should the simple loop be left for implementation by the users, and the class would then only contain building ansatz and making measurements?
Sampler, and thenDiagonalEstimatoris created, so we can have both the eigenvalue and the eigenstate. In Falqon we can't use theDiagonalEstimatorbecause the commutator Hamiltonian is not diagonal. How to manage that? Should the class constructor ask for bothSamplerandEstimator?Thanks