Manage edge case of pickling instmap.#9487
Merged
mergify[bot] merged 2 commits intoJan 31, 2023
Merged
Conversation
nkanazawa1989
added
stable backport potential
nkanazawa1989
requested review from
a team,
eggerdj and
wshanks
as code owners
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
nkanazawa1989
force-pushed
the
fix/typecast_def_arguments
branch
from
7af6f6b to
988a179
Compare
Pull Request Test Coverage Report for Build 4054589799
💛 - Coveralls |
mtreinish
approved these changes
Jan 31, 2023
mergify Bot
added a commit
that referenced
this pull request
Jan 31, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 8af4045)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a followup PR of #8885 for (edge case) bug fix. When
InstructionScheduleMap.addis called withargumentsand non-picklable value is specified (such as python dict key), parallel transpile will fail with the inst map due to this line.https://github.com/Qiskit/qiskit-terra/blob/a3b359b899d5d963272a7b424c8a283bc6bd4c0d/qiskit/compiler/transpiler.py#L365-L368
Details and comments
See new test case for code to reproduce the bug. This PR typecast
argumentsto python list so that any iterable is stored in the picklable format.