Add missing test coverage for RZXCalibration builder with target#9416
Merged
Conversation
mtreinish
added
the
Changelog: None
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
In the recently merged Qiskit#9343 support for using the Target directly was added to the RZXCalibrartionBuilder family of passes. However, test coverage in that PR was omitted by mistake for that pass (other passes in the PR were covered). There was a bug in the code change introduced in that PR which caused an error on initialization if a target were specified without an InstructionScheduleMap (which was the intent of the new target kwarg). This commit fixes the logic bug in the pass and adds test coverage to ensure specifying only a target continues to work moving forward.
mtreinish
force-pushed
the
fix-rzx-cal-build-target
branch
from
a605777 to
93e96c4
Compare
Pull Request Test Coverage Report for Build 3986520975
💛 - Coveralls |
nkanazawa1989
approved these changes
Jan 23, 2023
Contributor
nkanazawa1989
left a comment
nkanazawa1989
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the recently merged #9343 support for using the Target directly was added to the RZXCalibrartionBuilder family of passes. However, test coverage in that PR was omitted by mistake for that pass (other passes in the PR were covered). There was a bug in the code change introduced in that PR which caused an error on initialization if a target were specified without an InstructionScheduleMap (which was the intent of the new target kwarg). This commit fixes the logic bug in the pass and adds test coverage to ensure specifying only a target continues to work moving forward.
Details and comments