-
Notifications
You must be signed in to change notification settings - Fork 2.9k
add gaussian square echo pulse #9370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
cd37e22
add gaussian square echo pulse
miamico 859c451
address some PR comments
miamico 760aa7c
fixed parameters of symbolicpulse
miamico fca8fd6
adding math description and reference
miamico 2895969
change variable names
miamico 755d16e
fix lint
miamico 6f73a4c
remove width_echo parameter
miamico e1c731e
fix lint
miamico b083550
add release notes
miamico 0c1ba46
fix conflicts
miamico d94fcc7
address some PR comments
miamico 3d310c7
fixed parameters of symbolicpulse
miamico a1df97f
adding math description and reference
miamico a331c36
change variable names
miamico 0d695dc
fix lint
miamico bfd2c5d
remove width_echo parameter
miamico 7d79645
fix lint
miamico 7ff1871
add release notes
miamico f1f5a90
Merge branch 'main' of github.com:miamico/miamico-gse
miamico 75427a9
Update first paragraph
miamico 310b727
Update amp param to float
miamico f3c1e50
Update angle def param to float
miamico b18df11
Update amp constrain
miamico 877b285
drafting tests
miamico 16f2b33
update docstring
miamico bba03a0
finish up test
miamico bbeba66
Merge branch 'main' into main
miamico 4ead034
fix missing pulses from init
miamico d012580
addding Cos
miamico 41af294
Merge branch 'main' of github.com:miamico/miamico-gse
miamico 061aac4
missing sin
miamico d0d04ce
fixed tests
miamico 050c001
black formatting
miamico fab388b
break string
miamico cb0749e
fixing strings
miamico 170370e
reformatting
miamico 92c4b29
fix lint
miamico 17944ca
fixing last things
miamico ecc70c6
fix tests
miamico 5259ff5
fix black
miamico 686f342
Merge branch 'main' into main
miamico a0575d3
fix another test
miamico bff8bab
fix amp validation
miamico b4851fc
Merge branch 'main' of github.com:miamico/miamico-gse
miamico a55abd7
Merge branch 'main' into main
miamico 257fd43
fixing docstring
miamico 75183f2
Merge branch 'main' of github.com:miamico/miamico-gse
miamico 97a1e5f
Merge branch 'main' into main
miamico bb744bd
Update qiskit/pulse/library/symbolic_pulses.py
miamico 8be636a
Merge branch 'main' into main
miamico 769b145
Merge branch 'main' into main
miamico 88f045f
rename to gaussian_square_echo
miamico be39a8f
Merge branch 'main' of github.com:miamico/miamico-gse
miamico efb3b07
fix lint
miamico 41647e1
Update qiskit/qobj/converters/pulse_instruction.py
miamico 4328ce2
Update releasenotes/notes/gaussian-square-echo-pulse-84306f1a02e2bb28…
miamico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -142,6 +142,7 @@ | |
| Gaussian, | ||
| GaussianSquare, | ||
| GaussianSquareDrag, | ||
| gaussian_square_echo, | ||
| Sin, | ||
| Cos, | ||
| Sawtooth, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
releasenotes/notes/gaussian-square-echo-pulse-84306f1a02e2bb28.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| features: | ||
| - | | ||
| Add new :meth:`~qiskit.pulse.gaussian_square_echo` pulse shape. This pulse | ||
| is composed by three :class:`~qiskit.pulse.GaussianSquare` pulses. The | ||
| first two are echo pulses with duration half of the total duration and | ||
| implement rotary tones. The third pulse is a cancellation tone that lasts | ||
| the full duration of the pulse and implements correcting single qubit | ||
| rotations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a merging error. Those pulses should not be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, just pushed a fix for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like these are still removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now only the
Sinis still missing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully they're all back in now