Skip to content

[Test] Pin maximum python version in CI to <3.11.1#9296

Merged
1ucian0 merged 2 commits intoQiskit:mainfrom
Cryoris:pin-py-311
Dec 19, 2022
Merged

[Test] Pin maximum python version in CI to <3.11.1#9296
1ucian0 merged 2 commits intoQiskit:mainfrom
Cryoris:pin-py-311

Conversation

@Cryoris
Copy link
Collaborator

@Cryoris Cryoris commented Dec 16, 2022

Summary

The CI jobs on both Mac and Linux fail with Python 3.11.1, see also #9291. While this is not a fix, using Python 3.11.0 can unblock the CI until we track down the issue that seems to be coming from wrapping TestClass.

Details and comments

Not actually sure if this works, so this PR tests the fix by triggering the CI.

@Cryoris Cryoris requested a review from a team as a code owner December 16, 2022 17:08
@qiskit-bot
Copy link
Collaborator

qiskit-bot commented Dec 16, 2022

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Dec 16, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3720032668

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 84.607%
Files with Coverage Reduction New Missed Lines %
src/sabre_swap/layer.rs 2 98.95%
Totals Coverage Status
Change from base Build 3696577461: 0.04%
Covered Lines: 63864
Relevant Lines: 75483
💛 - Coveralls

@wshanks
Copy link
Contributor

wshanks commented Dec 16, 2022

It looks like it worked but there is no 3.11.0 available for Mac 😞

@Cryoris Cryoris changed the title [Test] Pin maximum python version in CI to 3.11.0 [Test] Pin maximum python version in CI to <3.11.1 Dec 17, 2022
@HuangJunye HuangJunye mentioned this pull request Dec 19, 2022
Open
@1ucian0 1ucian0 merged commit 07e0a2f into Qiskit:main Dec 19, 2022
@1ucian0 1ucian0 mentioned this pull request Dec 19, 2022
Closed
wshanks added a commit to wshanks/qiskit-terra that referenced this pull request Dec 19, 2022
@wshanks
Revert "[Test] Pin maximum python version in CI to <3.11.1 (Qiskit#9296…
00131ab 
…)"

This reverts commit 07e0a2f.
@t-imamichi
Copy link
Member

t-imamichi commented Dec 20, 2022

I think it is necessary for the stable branch. There is another pending PR to fix the stable branch #9277. We need to merge them all.

ihincks added a commit to ihincks/qiskit-terra that referenced this pull request Dec 20, 2022
@ihincks
Revert "[Test] Pin maximum python version in CI to <3.11.1 (Qiskit#9296…
bcbfb0f 
…)"

This reverts commit 07e0a2f.
mergify bot added a commit that referenced this pull request Jan 10, 2023
@wshanks @Cryoris @mergify
Update qiskit.utils.wrap_method for Python 3.11 (#9310)
0344a1c 
* Revert "[Test] Pin maximum python version in CI to <3.11.1 (#9296)"

This reverts commit 07e0a2f.

* Do not treat __init_subclass__ as a special type method

* Release note

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Use inspect.getattr_static to bypass descriptor call

* Update release note

* Update wrap_method test

* Adjust wording on release note

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jan 10, 2023
@wshanks @Cryoris @mergify
Update qiskit.utils.wrap_method for Python 3.11 (#9310)
797c5b0 
* Revert "[Test] Pin maximum python version in CI to <3.11.1 (#9296)"

This reverts commit 07e0a2f.

* Do not treat __init_subclass__ as a special type method

* Release note

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Use inspect.getattr_static to bypass descriptor call

* Update release note

* Update wrap_method test

* Adjust wording on release note

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 0344a1c)
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request Jan 11, 2023
@wshanks @Cryoris
@mergify @king-p3nguin
Update qiskit.utils.wrap_method for Python 3.11 (Qiskit#9310)
2308027 
* Revert "[Test] Pin maximum python version in CI to <3.11.1 (Qiskit#9296)"

This reverts commit 07e0a2f.

* Do not treat __init_subclass__ as a special type method

* Release note

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Use inspect.getattr_static to bypass descriptor call

* Update release note

* Update wrap_method test

* Adjust wording on release note

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cryoris added a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
@Cryoris
[Test] Pin maximum python version in CI to <3.11.1 (Qiskit#9296)
abfae0d 
* pin max python version to 3.11.0

* further restrict MacOS to 3.10
Cryoris added a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
@wshanks @Cryoris @mergify
Update qiskit.utils.wrap_method for Python 3.11 (Qiskit#9310)
00b3442 
* Revert "[Test] Pin maximum python version in CI to <3.11.1 (Qiskit#9296)"

This reverts commit 07e0a2f.

* Do not treat __init_subclass__ as a special type method

* Release note

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Use inspect.getattr_static to bypass descriptor call

* Update release note

* Update wrap_method test

* Adjust wording on release note

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Jan 12, 2023
@wshanks @Cryoris
@mergify @jakelishman
Update qiskit.utils.wrap_method for Python 3.11 (Qiskit#9310)
a77284a 
* Revert "[Test] Pin maximum python version in CI to <3.11.1 (Qiskit#9296)"

This reverts commit 07e0a2f.

* Do not treat __init_subclass__ as a special type method

* Release note

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Use inspect.getattr_static to bypass descriptor call

* Update release note

* Update wrap_method test

* Adjust wording on release note

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 0344a1c)
mergify bot pushed a commit that referenced this pull request Jan 12, 2023
@jakelishman @Cryoris @wshanks
Fix stable tests (#9368)
41820e2 
* Fix NumPy 1.24.0 compatibility and pin `coverage<7.0` (#9305)

* fix Kraus from (array, None)

* fix triu_to_dense test

* fix instruction comparison

* skip snobfit if numpy 1.24.0 or above is installed

Co-authored-by: ElePT <57907331+ElePT@users.noreply.github.com>

* pin coverage <7.0

* add links to Kraus and snobfit issues

* retrigger CI

Co-authored-by: ElePT <57907331+ElePT@users.noreply.github.com>
(cherry picked from commit 9733fc0)

* Update `qiskit.utils.wrap_method` for Python 3.11 (#9310)

* Revert "[Test] Pin maximum python version in CI to <3.11.1 (#9296)"

This reverts commit 07e0a2f.

* Do not treat __init_subclass__ as a special type method

* Release note

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Use inspect.getattr_static to bypass descriptor call

* Update release note

* Update wrap_method test

* Adjust wording on release note

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 0344a1c)

* Relax constraints on jupyter-core and ipywidgets (#9364)

These were originally added in #9105 and #9272 respectively, but the
original problem package `seaborn` has released since then, which may
have fixed things.

This removes some now-unnecessary suppressions from image-related
packages, and adds the new suppression for the pyzmq problem, which is
Jupyter's domain to handle.  The extra environment variable in the
images test run is to eagerly move to new default behaviour starting in
jupyter-core 6; there is no need for us to pin the package too low,
since this warning is just encouraging people to proactively test the
new behaviour, and it doesn't cause our suite problems.

* Refactor coverage CI workflow (#9361)

This relaxes the constraint on `coverage` added in #9305.  The issue
there is actually the now unmaintained `coveragepy-lcov` package is not
compatible with Coverage.py 7.0.  However, we only needed
`coveragepy-lcov` to convert Coverage's format into LCOV, which is a
feature Coverage has had itself since version 6.0.

This commit also updates some parts of the coverage workflow that were
old:

- there are new versions of the Actions `checkout` and `setup-python`,
  which swap to using Node 16 rather than Node 12, which is deprecated
  in GHA
- `grcov` is packaged and installable from `cargo` now, rather than
  needing a manual hard-coded pull from GitHub
- we can have `grcov` only keep the parts we care about immediately,
  rather than converting everything and later discarding it

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 7955d92)

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: Will Shanks <willshanks@us.ibm.com>
ElePT pushed a commit to ElePT/qiskit-algorithms that referenced this pull request Jul 27, 2023
@wshanks @Cryoris @mergify
Update qiskit.utils.wrap_method for Python 3.11 (Qiskit/qiskit#9310)
55e1b80 
* Revert "[Test] Pin maximum python version in CI to <3.11.1 (Qiskit/qiskit#9296)"

This reverts commit 07e0a2fc79bada7c1fbf0594f4ad33934f70b7e2.

* Do not treat __init_subclass__ as a special type method

* Release note

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Use inspect.getattr_static to bypass descriptor call

* Update release note

* Update wrap_method test

* Adjust wording on release note

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1ucian0 1ucian0 1ucian0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Cryoris @qiskit-bot @coveralls @wshanks @t-imamichi @1ucian0