Skip to content

Pin jupyter-core to < 5.0.0 (backport #9105)#9120

Merged
mergify[bot] merged 2 commits intostable/0.22from
mergify/bp/stable/0.22/pr-9105
Nov 11, 2022
Merged

Pin jupyter-core to < 5.0.0 (backport #9105)#9120
mergify[bot] merged 2 commits intostable/0.22from
mergify/bp/stable/0.22/pr-9105

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 11, 2022

This is an automatic backport of pull request #9105 done by Mergify.
Cherry-pick of 29c56a3 has failed:

On branch mergify/bp/stable/0.22/pr-9105
Your branch is up to date with 'origin/stable/0.22'.

You are currently cherry-picking commit 29c56a3c5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   constraints.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

The recent release of jupyter-core 5.0.0 started emitting a deprecation
warning during the image comparison tests which is causing a failure
caused by usage in seasborn via ipywidgets. To workaround this in the
short term this commit set a constraint on the jupyter-core version. We
should remove this pin after seaborn and ipywidgets are updated, or we
add an explicit warning exclude to the test suite.

(cherry picked from commit 29c56a3)

# Conflicts:
#	constraints.txt
@mergify mergify bot requested a review from a team as a code owner November 11, 2022 11:51
@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Nov 11, 2022
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality automerge Changelog: None Do not include in the GitHub Release changelog. and removed conflicts used by mergify when there are conflicts in a port labels Nov 11, 2022
@mergify mergify bot merged commit 7b4afa5 into stable/0.22 Nov 11, 2022
@mtreinish mtreinish deleted the mergify/bp/stable/0.22/pr-9105 branch November 23, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: None Do not include in the GitHub Release changelog. type: qa Issues and PRs that relate to testing and code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants