🐛 fix deprecated Loader.load_module()#9078
Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
jakelishman
left a comment
There was a problem hiding this comment.
Thanks - I always forget the exact particulars of the import system, but this looks about right to me. I don't think there are any modules that are supposed to be "executed" (like programs) in Qiskit anyway.
Pull Request Test Coverage Report for Build 3437210643
💛 - Coveralls |
|
Just saw that CI wasn't really happy. Added a corresponding docstring to please the linter. |
jakelishman
left a comment
There was a problem hiding this comment.
Ah, thanks - sorry, I'd also not noticed that the PR had got stuck. It's a bit of a silly lint rule for things like this, but elsewhere it does help ensure that all our public API gets at least some documentation.
* 🐛 fix deprecated `Loader.load_module()` * 📝add docstring to please linter Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ee0b036)
* 🐛 fix deprecated `Loader.load_module()` * 📝add docstring to please linter Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ee0b036)
* 🐛 fix deprecated `Loader.load_module()` * 📝add docstring to please linter Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ee0b036) Co-authored-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
* 🐛 fix deprecated `Loader.load_module()` * 📝add docstring to please linter Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
This PR ports a fix from Qiskit/rustworkx#728 that fixes the following
ImportWarningunderPython>=3.10ImportWarning: QiskitLoader.exec_module() not found; falling back to load_module()Details and comments
Some further context can be found in the corresponding retworkx PR Qiskit/rustworkx#728.
The underlying code was introduced in #5089.
Fixes #8853.