Fix VQE result, add ansatz#8816
Merged
Merged
Conversation
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Cryoris
reviewed
Sep 30, 2022
Pull Request Test Coverage Report for Build 3161882352
💛 - Coveralls |
Co-authored-by: Julien Gacon <gaconju@gmail.com>
…into vqe-result-fix Apply suggestion
ElePT
commented
Sep 30, 2022
…into vqe-result-fix Pull suggestion
ElePT
commented
Sep 30, 2022
woodsp-ibm
approved these changes
Sep 30, 2022
5 tasks
ElePT
added a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Add ansatz to result * Add ansatz to eigen. results * Update qiskit/algorithms/minimum_eigensolvers/minimum_eigensolver.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * Copy ansatz * Apply comments * Change name to optimal_circuit(s) * add blank line * move optimal circuit to variational result * remove import Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
added a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* Add ansatz to result * Add ansatz to eigen. results * Update qiskit/algorithms/minimum_eigensolvers/minimum_eigensolver.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * Copy ansatz * Apply comments * Change name to optimal_circuit(s) * add blank line * move optimal circuit to variational result * remove import Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On #8702 and #8640, the
eigenstatewas removed from the eigen-result classes, which has affected certain workflows inqiskit-nature(@mrossinek).This PR adds the ansatz to the
eigensolver/minimum_eigensolverresults so that the eigenstates can be retrieved from the result directly (in other words, making the result self-contained). The code would look like:Details and comments
In the future, I believe the
VariationalResultclass should be reviewed, and potentially include thisansatzproperty. But so far the eigensolver result does not inherit fromVariationalResult, and for the sake of including this fix into the upcoming0.22release, I have decided to add it to the Eigen-results directly.