Skip to content

Pending deprecate algorithms#8703

Merged
mergify[bot] merged 11 commits into
Qiskit:mainfrom
manoelmarques:deprecation
Sep 27, 2022
Merged

Pending deprecate algorithms#8703
mergify[bot] merged 11 commits into
Qiskit:mainfrom
manoelmarques:deprecation

Conversation

@manoelmarques
Copy link
Copy Markdown
Member

@manoelmarques manoelmarques commented Sep 7, 2022

Summary

Details and comments

@manoelmarques manoelmarques self-assigned this Sep 7, 2022
@manoelmarques manoelmarques requested review from a team and woodsp-ibm as code owners September 7, 2022 17:20
@qiskit-bot
Copy link
Copy Markdown
Collaborator

qiskit-bot commented Sep 7, 2022

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3137726780

  • 27 of 27 (100.0%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 84.452%
Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/squ.py 2 79.78%
qiskit/pulse/library/waveform.py 3 91.49%
Totals Coverage Status
Change from base Build 3137724188: -0.002%
Covered Lines: 59873
Relevant Lines: 70896
💛 - Coveralls

woodsp-ibm
woodsp-ibm reviewed Sep 7, 2022
View reviewed changes
Comment thread releasenotes/notes/pending-deprecate-min-eigen-solvers-fa4341e1014e4df0.yaml Outdated
manoelmarques and others added 2 commits September 8, 2022 09:41
@manoelmarques @woodsp-ibm
Update releasenotes/notes/pending-deprecate-min-eigen-solvers-fa4341e…
ce73623 
…1014e4df0.yaml

Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
@manoelmarques
Merge branch 'main' into deprecation
95a6175
@woodsp-ibm woodsp-ibm added this to the 0.22 milestone Sep 12, 2022
@woodsp-ibm
Copy link
Copy Markdown
Member

woodsp-ibm commented Sep 12, 2022

LGTM like #8651 lets get the new algos merged and merge this afterwards.

@woodsp-ibm woodsp-ibm added the Changelog: Deprecated Add a "Deprecated" entry in the GitHub Release changelog. label Sep 16, 2022
@woodsp-ibm woodsp-ibm mentioned this pull request Sep 19, 2022
Closed
@jakelishman
Copy link
Copy Markdown
Member

jakelishman commented Sep 21, 2022

Just a minor comment: if there's no merge conflicts and no test failures, there's no need to "update branch" - the bot will automatically handle it efficiently when the PR is tagged for merge, and in the interim, doing it jams CI for other PRs.

@woodsp-ibm woodsp-ibm mentioned this pull request Sep 23, 2022
Merged
woodsp-ibm
woodsp-ibm approved these changes Sep 27, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primitive versions replacing these now pending deprecated algos have been merged so this can be merged now too.

@jakelishman
Copy link
Copy Markdown
Member

jakelishman commented Sep 27, 2022

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Sep 27, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify Bot merged commit 293ab43 into Qiskit:main Sep 27, 2022
@woodsp-ibm woodsp-ibm mentioned this pull request Sep 30, 2022
Closed
@manoelmarques manoelmarques deleted the deprecation branch October 27, 2022 20:15
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
@manoelmarques @woodsp-ibm @mergify
Pending deprecate algorithms (Qiskit#8703)
76da497 
* Pending deprecate algorithms

* Update releasenotes/notes/pending-deprecate-min-eigen-solvers-fa4341e1014e4df0.yaml

Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>

Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
@manoelmarques @woodsp-ibm @mergify
Pending deprecate algorithms (Qiskit/qiskit#8703)
0f23af3 
* Pending deprecate algorithms

* Update releasenotes/notes/pending-deprecate-min-eigen-solvers-fa4341e1014e4df0.yaml

Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>

Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

Assignees

@manoelmarques manoelmarques

Labels

Changelog: Deprecated Add a "Deprecated" entry in the GitHub Release changelog.

Projects

None yet

Milestone

0.22

Development

Successfully merging this pull request may close these issues.

5 participants

@manoelmarques @qiskit-bot @coveralls @woodsp-ibm @jakelishman