-
Notifications
You must be signed in to change notification settings - Fork 3k
Adds observable evaluator with primitives. #8683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
39c9735
Added observables_evaluator.py with primitives.
99adde7
Added ListOrDict support to observables_evaluator.py.
6462bb0
Included CR suggestions.
d287c2f
Applied some CR comments.
80a2e2b
Added reno.
4c40e00
Support for 0 operator.
2bcf07b
Add pending deprecation
manoelmarques 4adfd1b
Merge branch 'main' into observable-eval-primitives
manoelmarques f5c3eaf
Code refactoring.
65a2cab
Merge branch 'main' into observable-eval-primitives
a57b073
Merge remote-tracking branch 'origin/observable-eval-primitives' into…
553714c
Code refactoring.
fc842a9
Merge branch 'main' into observable-eval-primitives
92d6515
Improved reno.
9ba37ed
Returning variances and shots.
24aa2bf
Unit test fix.
00d9d11
Reduced use of opflow.
44b7959
Handle empty inputs gracefully.
12d9a68
Merge branch 'main' into observable-eval-primitives
773b124
Applied CR comments.
6a968f3
Merge remote-tracking branch 'origin/observable-eval-primitives' into…
d248e44
Applied CR comments.
a7e615f
Merge branch 'main' into observable-eval-primitives
fad2caa
Eliminated cyclic import.
c8f0105
Merge branch 'main' into observable-eval-primitives
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| # This code is part of Qiskit. | ||
| # | ||
| # (C) Copyright IBM 2021, 2022. | ||
| # | ||
| # This code is licensed under the Apache License, Version 2.0. You may | ||
| # obtain a copy of this license in the LICENSE.txt file in the root directory | ||
| # of this source tree or at http://www.apache.org/licenses/LICENSE-2.0. | ||
| # | ||
| # Any modifications or derivative works of this code must retain this | ||
| # copyright notice, and modified files need to carry a notice indicating | ||
| # that they have been altered from the originals. | ||
| """Evaluator of auxiliary operators for algorithms.""" | ||
| from __future__ import annotations | ||
|
|
||
| from typing import Tuple, List | ||
|
|
||
| import numpy as np | ||
|
|
||
| from qiskit import QuantumCircuit | ||
| from qiskit.opflow import ( | ||
| PauliSumOp, | ||
| ) | ||
|
dlasecki marked this conversation as resolved.
Outdated
|
||
| from . import AlgorithmError | ||
| from .list_or_dict import ListOrDict | ||
| from ..primitives import EstimatorResult, BaseEstimator | ||
| from ..quantum_info.operators.base_operator import BaseOperator | ||
|
|
||
|
|
||
| def eval_observables( | ||
|
dlasecki marked this conversation as resolved.
Outdated
|
||
| estimator: BaseEstimator, | ||
| quantum_state: QuantumCircuit, | ||
| observables: ListOrDict[BaseOperator | PauliSumOp], | ||
| threshold: float = 1e-12, | ||
| ) -> ListOrDict[Tuple[complex, complex]]: | ||
| """ | ||
| Accepts a sequence of operators and calculates their expectation values - means | ||
| and standard deviations. They are calculated with respect to a quantum state provided. A user | ||
| can optionally provide a threshold value which filters mean values falling below the threshold. | ||
|
|
||
| Args: | ||
| estimator: An estimator primitive used for calculations. | ||
| quantum_state: An unparametrized quantum circuit representing a quantum state that | ||
| expectation values are computed against. | ||
| observables: A list or a dictionary of operators whose expectation values are to be | ||
| calculated. | ||
| threshold: A threshold value that defines which mean values should be neglected (helpful for | ||
| ignoring numerical instabilities close to 0). | ||
|
|
||
| Returns: | ||
| A list or a dictionary of tuples (mean, standard deviation). | ||
|
dlasecki marked this conversation as resolved.
Outdated
|
||
|
|
||
| Raises: | ||
| ValueError: If a ``quantum_state`` with free parameters is provided. | ||
| AlgorithmError: If a primitive job is not successful. | ||
| """ | ||
|
|
||
| if ( | ||
| isinstance(quantum_state, QuantumCircuit) # Statevector cannot be parametrized | ||
|
dlasecki marked this conversation as resolved.
Outdated
|
||
| and len(quantum_state.parameters) > 0 | ||
| ): | ||
| raise ValueError( | ||
| "A parametrized representation of a quantum_state was provided. It is not " | ||
| "allowed - it cannot have free parameters." | ||
| ) | ||
| if isinstance(observables, dict): | ||
| observables_list = list(observables.values()) | ||
| else: | ||
| observables_list = observables | ||
| quantum_state = [quantum_state] * len(observables) | ||
| try: | ||
| estimator_job = estimator.run(quantum_state, observables_list) | ||
| expectation_values = estimator_job.result().values | ||
| except Exception as exc: | ||
| raise AlgorithmError("The primitive job failed!") from exc | ||
|
|
||
| std_devs = _compute_std_devs(estimator_job, len(expectation_values)) | ||
|
|
||
| # Discard values below threshold | ||
| observables_means = expectation_values * (np.abs(expectation_values) > threshold) | ||
| # zip means and standard deviations into tuples | ||
| observables_results = list(zip(observables_means, std_devs)) | ||
|
|
||
| # Return None eigenvalues for None operators if observables is a list. | ||
| return _prepare_result(observables_results, observables) | ||
|
|
||
|
|
||
| def _prepare_result( | ||
| observables_results: List[Tuple[complex, complex]], | ||
|
dlasecki marked this conversation as resolved.
Outdated
|
||
| observables: ListOrDict[BaseOperator | PauliSumOp], | ||
| ) -> ListOrDict[Tuple[complex, complex]]: | ||
| """ | ||
| Prepares a list of eigenvalues and standard deviations from ``observables_results`` and | ||
| ``observables``. | ||
|
|
||
| Args: | ||
| observables_results: A list of of tuples (mean, standard deviation). | ||
| observables: A list or a dictionary of operators whose expectation values are to be | ||
| calculated. | ||
|
|
||
| Returns: | ||
| A list or a dictionary of tuples (mean, standard deviation). | ||
| """ | ||
|
|
||
| if isinstance(observables, list): | ||
| observables_eigenvalues = [None] * len(observables) | ||
| key_value_iterator = enumerate(observables_results) | ||
| else: | ||
| observables_eigenvalues = {} | ||
| key_value_iterator = zip(observables.keys(), observables_results) | ||
|
|
||
| for key, value in key_value_iterator: | ||
| if observables[key] is not None: | ||
| observables_eigenvalues[key] = value | ||
| return observables_eigenvalues | ||
|
|
||
|
|
||
| def _compute_std_devs( | ||
| estimator_result: EstimatorResult, | ||
| results_length: int, | ||
| ) -> List[complex | None]: | ||
|
dlasecki marked this conversation as resolved.
Outdated
dlasecki marked this conversation as resolved.
Outdated
|
||
| """ | ||
| Calculates a list of standard deviations from expectation values of observables provided. | ||
|
|
||
| Args: | ||
| estimator_result: An estimator result. | ||
| results_length: Number of expectation values calculated. | ||
|
|
||
| Returns: | ||
| A list of standard deviations. | ||
| """ | ||
| if not estimator_result.metadata: | ||
| return [0] * results_length | ||
|
|
||
| std_devs = [] | ||
| for metadata in estimator_result.metadata: | ||
| if metadata and "variance" in metadata.keys() and "shots" in metadata.keys(): | ||
|
dlasecki marked this conversation as resolved.
Outdated
|
||
| variance = metadata["variance"] | ||
| shots = metadata["shots"] | ||
| std_devs.append(np.sqrt(variance / shots)) | ||
| else: | ||
| std_devs.append(0) | ||
|
dlasecki marked this conversation as resolved.
Outdated
|
||
|
|
||
| return std_devs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| # This code is part of Qiskit. | ||
| # | ||
| # (C) Copyright IBM 2022. | ||
| # | ||
| # This code is licensed under the Apache License, Version 2.0. You may | ||
| # obtain a copy of this license in the LICENSE.txt file in the root directory | ||
| # of this source tree or at http://www.apache.org/licenses/LICENSE-2.0. | ||
| # | ||
| # Any modifications or derivative works of this code must retain this | ||
| # copyright notice, and modified files need to carry a notice indicating | ||
| # that they have been altered from the originals. | ||
| """Tests evaluator of auxiliary operators for algorithms.""" | ||
| from __future__ import annotations | ||
| import unittest | ||
| from typing import Tuple | ||
|
|
||
| from test.python.algorithms import QiskitAlgorithmsTestCase | ||
| import numpy as np | ||
| from ddt import ddt, data | ||
|
|
||
| from qiskit.algorithms.list_or_dict import ListOrDict | ||
| from qiskit.quantum_info.operators.base_operator import BaseOperator | ||
| from qiskit.algorithms.observables_evaluator import eval_observables | ||
| from qiskit.primitives import Estimator | ||
| from qiskit.quantum_info import Statevector | ||
| from qiskit import QuantumCircuit | ||
| from qiskit.circuit.library import EfficientSU2 | ||
| from qiskit.opflow import ( | ||
| PauliSumOp, | ||
| ) | ||
| from qiskit.utils import algorithm_globals | ||
|
|
||
|
|
||
| @ddt | ||
| class TestObservablesEvaluator(QiskitAlgorithmsTestCase): | ||
| """Tests evaluator of auxiliary operators for algorithms.""" | ||
|
|
||
| def setUp(self): | ||
| super().setUp() | ||
| self.seed = 50 | ||
| algorithm_globals.random_seed = self.seed | ||
|
|
||
| self.threshold = 1e-8 | ||
|
|
||
| def get_exact_expectation( | ||
| self, ansatz: QuantumCircuit, observables: ListOrDict[BaseOperator | PauliSumOp] | ||
| ): | ||
| """ | ||
| Calculates the exact expectation to be used as an expected result for unit tests. | ||
| """ | ||
| if isinstance(observables, dict): | ||
| observables_list = list(observables.values()) | ||
| else: | ||
| observables_list = observables | ||
| # the exact value is a list of (mean, variance) where we expect 0 variance | ||
| exact = [ | ||
| (Statevector(ansatz).expectation_value(observable), 0) | ||
| for observable in observables_list | ||
| ] | ||
|
|
||
| if isinstance(observables, dict): | ||
| return dict(zip(observables.keys(), exact)) | ||
|
|
||
| return exact | ||
|
|
||
| def _run_test( | ||
| self, | ||
| expected_result: ListOrDict[Tuple[complex, complex]], | ||
| quantum_state: QuantumCircuit, | ||
| decimal: int, | ||
| observables: ListOrDict[BaseOperator | PauliSumOp], | ||
| estimator: Estimator, | ||
| ): | ||
| result = eval_observables(estimator, quantum_state, observables, self.threshold) | ||
|
|
||
| if isinstance(observables, dict): | ||
| np.testing.assert_equal(list(result.keys()), list(expected_result.keys())) | ||
| np.testing.assert_array_almost_equal( | ||
| list(result.values()), list(expected_result.values()), decimal=decimal | ||
| ) | ||
| else: | ||
| np.testing.assert_array_almost_equal(result, expected_result, decimal=decimal) | ||
|
|
||
| @data( | ||
| [ | ||
| PauliSumOp.from_list([("II", 0.5), ("ZZ", 0.5), ("YY", 0.5), ("XX", -0.5)]), | ||
| PauliSumOp.from_list([("II", 2.0)]), | ||
| ], | ||
| [ | ||
| PauliSumOp.from_list([("ZZ", 2.0)]), | ||
| ], | ||
| { | ||
| "op1": PauliSumOp.from_list([("II", 2.0)]), | ||
| "op2": PauliSumOp.from_list([("II", 0.5), ("ZZ", 0.5), ("YY", 0.5), ("XX", -0.5)]), | ||
| }, | ||
| { | ||
| "op1": PauliSumOp.from_list([("ZZ", 2.0)]), | ||
| }, | ||
| ) | ||
| def test_eval_observables(self, observables: ListOrDict[BaseOperator | PauliSumOp]): | ||
| """Tests evaluator of auxiliary operators for algorithms.""" | ||
|
|
||
| ansatz = EfficientSU2(2) | ||
| parameters = np.array( | ||
| [1.2, 4.2, 1.4, 2.0, 1.2, 4.2, 1.4, 2.0, 1.2, 4.2, 1.4, 2.0, 1.2, 4.2, 1.4, 2.0], | ||
| dtype=float, | ||
| ) | ||
|
|
||
| bound_ansatz = ansatz.bind_parameters(parameters) | ||
| states = bound_ansatz | ||
| expected_result = self.get_exact_expectation(bound_ansatz, observables) | ||
| estimator = Estimator() | ||
| decimal = 6 | ||
| self._run_test( | ||
| expected_result, | ||
| states, | ||
| decimal, | ||
| observables, | ||
| estimator, | ||
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.