adding FakePerth#8344
Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3070775131
💛 - Coveralls |
1ucian0
force-pushed
the
ibm_perth/fakebackend
branch
from
bdb45f1 to
dc7df1e
Compare
HuangJunye
left a comment
HuangJunye
left a comment
There was a problem hiding this comment.
Overall LGTM. Just one small comment.
| from qiskit.providers.fake_provider import fake_backend | ||
|
|
||
|
|
||
| class FakePerthV2(fake_backend.FakeBackendV2): |
There was a problem hiding this comment.
If there is no V1 variant we don't need to mark this as V2
| class FakePerthV2(fake_backend.FakeBackendV2): | |
| class FakePerth(fake_backend.FakeBackendV2): |
There was a problem hiding this comment.
sounds good. Done in 06a0517 . So, the type is the way to check the version?
There was a problem hiding this comment.
You can either type check, or there is a .version class attribute set in the base abstract class. So you can do something like: backend.version >= 2 or something like that.
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
LGTM, thanks for the updates
|
Awesome. Ill update the rest. |
mtreinish
added
the
Changelog: Added
* adding FakePerth * Update releasenotes/notes/ibm_perth-5b1e9308dc302e2e.yaml * Mock over Fake * remove V1 * removing v2 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* adding FakePerth * Update releasenotes/notes/ibm_perth-5b1e9308dc302e2e.yaml * Mock over Fake * remove V1 * removing v2 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* adding FakePerth * Update releasenotes/notes/ibm_perth-5b1e9308dc302e2e.yaml * Mock over Fake * remove V1 * removing v2 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* adding FakePerth * Update releasenotes/notes/ibm_perth-5b1e9308dc302e2e.yaml * Mock over Fake * remove V1 * removing v2 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
5 participants
This PRs adds FakePerth based on
ibm_perth.