Remove stale note about pending QPY support for SymbolicPulse#8289
Merged
mergify[bot] merged 2 commits intoJul 4, 2022
Merged
Conversation
The support for serializing SymbolicPulse objects using QPY was added in PR Qiskit#7300 and has been released as part of 0.21.0. However, the documentation for the SymbolicPulse class had a note saying the QPY support was pending. This was necessary when the SymbolicPulse class was added in Qiskit#7821 because it was unclear when we'd be able to add the QPY support. But, Qiskit#7300 was updated and merged soon after Qiskit#7821, but we neglected to remove that note. This commit corrects the oversight and removes the stale note.
mtreinish
added
documentation
mtreinish
requested review from
a team,
DanPuzzuoli,
eggerdj and
nkanazawa1989
as code owners
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2609879129
💛 - Coveralls |
jakelishman
approved these changes
Jul 4, 2022
mergify Bot
added a commit
that referenced
this pull request
Jul 4, 2022
The support for serializing SymbolicPulse objects using QPY was added in PR #7300 and has been released as part of 0.21.0. However, the documentation for the SymbolicPulse class had a note saying the QPY support was pending. This was necessary when the SymbolicPulse class was added in #7821 because it was unclear when we'd be able to add the QPY support. But, #7300 was updated and merged soon after #7821, but we neglected to remove that note. This commit corrects the oversight and removes the stale note. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 47c7c27)
mergify Bot
added a commit
that referenced
this pull request
Jul 4, 2022
…#8292) The support for serializing SymbolicPulse objects using QPY was added in PR #7300 and has been released as part of 0.21.0. However, the documentation for the SymbolicPulse class had a note saying the QPY support was pending. This was necessary when the SymbolicPulse class was added in #7821 because it was unclear when we'd be able to add the QPY support. But, #7300 was updated and merged soon after #7821, but we neglected to remove that note. This commit corrects the oversight and removes the stale note. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 47c7c27) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The support for serializing SymbolicPulse objects using QPY was added in
PR #7300 and has been released as part of 0.21.0. However, the
documentation for the SymbolicPulse class had a note saying the QPY
support was pending. This was necessary when the SymbolicPulse class was
added in #7821 because it was unclear when we'd be able to add the QPY
support. But, #7300 was updated and merged soon after #7821, but we
neglected to remove that note. This commit corrects the oversight and
removes the stale note.
Details and comments