Conversation
Randl
requested review from
a team,
nkanazawa1989 and
nonhermitian
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
HuangJunye
added
the
Community PR
| @time_range.setter | ||
| def time_range(self, new_range: Tuple[int, int]): | ||
| """Update time range to draw.""" | ||
| self._time_range = new_range | ||
|
|
There was a problem hiding this comment.
The reason is this: python/mypy#1465
It may be better just to leave a comment since its a mypy bug, but the change is cheap, so I just went for it (admittedly, I did it before I found out it was a bug)
There was a problem hiding this comment.
In that case, I would remove the change. The goal is not to be mypy-clean but to move towards a situation where mypy helps. I'm okay with mypy complaining for something it wont in the future (when the bug gets fixed)
Pull Request Test Coverage Report for Build 4550851518
💛 - Coveralls |
Randl
force-pushed
the
mypy-16
branch
5 times, most recently
from
e176e45 to
0c0ec22
Compare
|
@1ucian0 anything else required from me here? |
1ucian0
left a comment
1ucian0
left a comment
There was a problem hiding this comment.
I had another pass, some small things here and there. almost done.
|
@1ucian0 done |
* Fix visualization mypy errors * Suggested fixes
* Fix visualization mypy errors * Suggested fixes
* Fix visualization mypy errors * Suggested fixes
5 participants
Summary
Following discussion, I'm splitting #8187 by module.
Details and comments
The are ~240 errors left:
All error list
There are many errors which should be easy to fiix, e.g., passing integers instead of some more concrete class, or mixing
ints andfloats.I'm not sure why those errors appear:
if
DataTypesis the union of all those.