Open
Conversation
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
87f4bc6 to
2eeebe0
Compare
Pull Request Test Coverage Report for Build 5713433333
💛 - Coveralls |
Pull Request Test Coverage Report for Build 7370292470
💛 - Coveralls |
Contributor
Author
|
ping @jyu00 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following discussion, I'm splitting #8187 by module.
Details and comments
The are ~40 errors left:
All error list
There are some ignores added to decorated property, since it's currently is not supported by mypy.
That's already a bit to much to specify all of the problems. I'll try to list those I identified.
There are some errors in
qiskit/providers/basicaer/basicaertools.pydue to the fact thatGatesubclasses constructors are different from constructor ofGate.There are also multiple errors in
qiskit/providers/models/backendproperties.pydue to the fact thatqubit_propertycan return eithe dictionary or tuple depending on the runtime parameters.There are some more that I'm unsure about fixes, help is appreciated.