Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
qiskit/compiler/transpiler.py
Outdated
| # Get transpile_args to configure the circuit transpilation job(s) | ||
| if coupling_map in unique_transpile_args: | ||
| cmap_conf = unique_transpile_args["coupling_map"] | ||
| cmap_conf = unique_transpile_args["coupling_map"] # TODO: unique_transpile_args is a list |
There was a problem hiding this comment.
This looks like genuine type error, maybe it should be unique_transpile_args[coupling_map]?
|
Meanwhile closing since there are no meanigful changes left |
Pull Request Test Coverage Report for Build 5058128185
💛 - Coveralls |
Summary
Following discussion, I'm splitting #8187 by module.
Details and comments
The first two appear to be some kind of mypy problem: it can't distinguish between function and same named module due to import structure?
The next some are due to the fact that
Backendclass do not define any attributes, but rather its subclasses do. Finally, some errors are due to type cast mypy misses -- can be solved by explicit cast or changing variable name probably?