Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
AngeloDanducci
left a comment
There was a problem hiding this comment.
Took a look at this with mypy version 1.2.0 and I didn't see the corresponding errors on main, or on the commit prior to this one.
If you can reproduce them on 1.2.0 this seems like good low hanging fruit, but both without options and with the options I found in the discussion earlier (--ignore-missing-imports --no-strict-optional --allow-untyped-globals --allow-redefinition --show-error-codes) I couldn't see the errors this would fix.
|
I do get these with Though there was some discussion with @Cryoris @kevinsung regarding not including ignores as for now. In this case we should just close this one for now |
Summary
Following discussion, I'm splitting #8187 by module.
Details and comments
This fixes all the mypy errors in
extensionsas for now. Since the assignment to undefined attribute is the purpose of this code, I don't see better solution than just ignore those errors