Move QPY version regex construction to import time#8235
Merged
mergify[bot] merged 3 commits intoJun 24, 2022
Conversation
As pointed out by @nkanazawa1989 in Qiskit#8232 the regex construction added to the QPY interface functions in Qiskit#8200 can be a significant portion of the overall function time especially for smaller inputs. Especially as we're building it on every call interface function call. To ameliorate that cost this commit compiles the version regex a single time at the module level. This adds the overhead to import but it will only be done once which should be a net improvement in performance.
mtreinish
added
stable backport potential
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
jakelishman
previously approved these changes
Jun 24, 2022
Member
jakelishman
left a comment
jakelishman
left a comment
There was a problem hiding this comment.
Looks good to me - my quick search showed these two instances as the only uses of the regex as well (other than the test suite).
jakelishman
reviewed
Jun 24, 2022
jakelishman
approved these changes
Jun 24, 2022
Pull Request Test Coverage Report for Build 2556896243
💛 - Coveralls |
mergify Bot
added a commit
that referenced
this pull request
Jun 24, 2022
* Move QPY version regex construction to import time As pointed out by @nkanazawa1989 in #8232 the regex construction added to the QPY interface functions in #8200 can be a significant portion of the overall function time especially for smaller inputs. Especially as we're building it on every call interface function call. To ameliorate that cost this commit compiles the version regex a single time at the module level. This adds the overhead to import but it will only be done once which should be a net improvement in performance. * Fix regex flags usage Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ebf800a)
mergify Bot
added a commit
that referenced
this pull request
Jun 24, 2022
* Move QPY version regex construction to import time As pointed out by @nkanazawa1989 in #8232 the regex construction added to the QPY interface functions in #8200 can be a significant portion of the overall function time especially for smaller inputs. Especially as we're building it on every call interface function call. To ameliorate that cost this commit compiles the version regex a single time at the module level. This adds the overhead to import but it will only be done once which should be a net improvement in performance. * Fix regex flags usage Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ebf800a) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
rathishcholarajan
added a commit
to rathishcholarajan/qiskit-ibm-runtime
that referenced
this pull request
Jul 5, 2022
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
rathishcholarajan
added a commit
to Qiskit/qiskit-ibm-runtime
that referenced
this pull request
Jul 5, 2022
* Copy Qiskit/qiskit#8055 Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Copy qpy changes from Qiskit/qiskit#8093 Co-authored-by: Jake Lishman <jake@binhbar.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * Copy Qiskit/qiskit#8200 Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Copy of Qiskit/qiskit#7300 Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com> * Copy of Qiskit/qiskit#8235 Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Jake Lishman <jake@binhbar.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As pointed out by @nkanazawa1989 in #8232 the regex construction added
to the QPY interface functions in #8200 can be a significant portion of
the overall function time especially for smaller inputs. Especially as
we're building it on every call interface function call. To ameliorate
that cost this commit compiles the version regex a single time at the
module level. This adds the overhead to import but it will only be done
once which should be a net improvement in performance.
Details and comments