Skip to content

Add string representation for PassManagerConfig #8085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 3 commits into from
May 26, 2022
Merged

Add string representation for PassManagerConfig #8085

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad8ff03
Add string representation for PassManagerConfig
mtreinish May 18, 2022
647f8eb
Merge remote-tracking branch 'origin/main' into str-pm-config
mtreinish May 26, 2022
f1bcb57
Adjust tab indent and add tests
mtreinish May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions qiskit/transpiler/passmanager_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,3 +124,24 @@ def from_backend(cls, backend, **pass_manager_options):
res.target = backend.target

return res

def __str__(self):
return (
"Pass Manager Config:\n"
Comment on lines +138 to +139

@jakelishman jakelishman May 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel very strongly about this at all, but is it worth formatting it as

f"""
PassManagerConfig(
    initial_layout={self.initial_layout},
    basis_gates={self.basis_gates},
...
)
"""

so it can easily be copy-paste evaled back into an interpreter?

@mtreinish mtreinish May 19, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's useful to do that in this case because this is not actually going to be a repr string in this case. You won't be able to eval the output because several of the fields are more complex objects that have human readable outputs (InstructionScheduleMap, InstructionDurations, CouplingMap, Target, etc)

I personally was just looking for something that I could use for quick print debugging in #7789 that gave me output I could read to show what was getting passed to the PassManagerConfig

@jakelishman jakelishman May 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this - what I was suggesting is more like for repr anyway.

f"\tinitial_layout: {self.initial_layout}\n"
f"\tbasis_gates: {self.basis_gates}\n"
f"\tinst_map: {self.inst_map}\n"
f"\tcoupling_map: {self.coupling_map}\n"
f"\tlayout_method: {self.layout_method}\n"
f"\trouting_method: {self.routing_method}\n"
f"\ttranslation_method: {self.translation_method}\n"
f"\tscheduling_method: {self.scheduling_method}\n"
f"\tinstruction_durations: {self.instruction_durations}\n"
f"\tbackend_properties: {self.backend_properties}\n"
f"\tapproximation_degree: {self.approximation_degree}\n"
f"\tseed_transpiler: {self.seed_transpiler}\n"
f"\ttiming_constraints: {self.timing_constraints}\n"
f"\tunitary_synthesis_method: {self.unitary_synthesis_method}\n"
f"\tunitary_synthesis_plugin_config: {self.unitary_synthesis_plugin_config}\n"
f"\ttarget: {self.target}\n"
)