Fix dt units in test util function convert_to_target#8000
Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
mtreinish
left a comment
There was a problem hiding this comment.
Good catch, this lgtm. Just one comment on the release note and a suggestion on the unit test.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this
Pull Request Test Coverage Report for Build 2247717376
💛 - Coveralls |
* Multilpy dt value by conversion factor when reading from conf file. * Add simple test and release note. * Update releasenotes/notes/fix-target-dt-4d306f1e9b07f819.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit ce4f94d)
|
@kevinhartman Good catch. I thought I corrected the error when I made the FakeBackendV2 PR #7643 but actually introduced another error... a814fa7#diff-eb1c104ba5abb83f1ab8c8b159c2b5537b234aca17a448fa15cbc55d0461ece7L85-R109 qiskit-ibm-runtime has its own copy of backend_converter.py. It should be updated too. CC @rathishcholarajan |
* Multilpy dt value by conversion factor when reading from conf file. * Add simple test and release note. * Update releasenotes/notes/fix-target-dt-4d306f1e9b07f819.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit ce4f94d) Co-authored-by: Kevin Hartman <kevin@hart.mn>
…it#8000) * Multilpy dt value by conversion factor when reading from conf file. * Add simple test and release note. * Update releasenotes/notes/fix-target-dt-4d306f1e9b07f819.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Summary
Previously,
convert_to_targetwas readingdtfrom the configuration/conf file, expecting it to be in seconds, when it is actually in nanoseconds.The effect of this was that
FakeBackendV2targets would return aInstructionDurationswith all durations as0, since all durations round to0when divided by the erroneously largedtand converted to an integer.