Deprecate old paths for module-availability testers#7954
Merged
mergify[bot] merged 2 commits intoApr 20, 2022
Conversation
The canonical location for all of these is `qiskit.utils.optionals`, along with all the other import testers. Historically these objects were available from `qiskit.visualization` just because they were reused in several places within that module, and now a few downstream packages have begun importing from there. The alternate path was made available in Terra 0.20.
jakelishman
requested review from
a team,
nkanazawa1989 and
nonhermitian
as code owners
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
jakelishman
added
the
Changelog: Deprecated
Pull Request Test Coverage Report for Build 2198457317
💛 - Coveralls |
mtreinish
approved these changes
Apr 20, 2022
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
LGTM, glad to see a module level __getattr__ finally being used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The canonical location for all of these is
qiskit.utils.optionals,along with all the other import testers. Historically these objects
were available from
qiskit.visualizationjust because they were reusedin several places within that module, and now a few downstream packages
have begun importing from there. The alternate path was made available
in Terra 0.20.
Details and comments
Follow-on from #7525. Uses the Python 3.7+ module-level
__getattr__to make Matt happy!