Skip to content

Add IGate rules to standard equivalence library #7146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakelishman merged 10 commits into from
Oct 16, 2023
Merged

Add IGate rules to standard equivalence library #7146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8ead825
Add IGate rules to session equivalence library
mtreinish Oct 15, 2021
bd4f71a
Run black
mtreinish Oct 15, 2021
d79caab
Merge remote-tracking branch 'origin/main' into id-equivalence-lib
mtreinish Dec 1, 2022
c1bc5f8
Merge branch 'main' into id-equivalence-lib
mtreinish Dec 9, 2022
8c7b0c9
Merge branch 'main' into id-equivalence-lib
mtreinish Dec 9, 2022
c7fa3ec
Merge branch 'main' into id-equivalence-lib
mtreinish Jul 19, 2023
102ab00
Merge branch 'main' into id-equivalence-lib
mtreinish Sep 11, 2023
029e284
Update tests
mtreinish Sep 11, 2023
e9628de
Merge branch 'main' into id-equivalence-lib
mtreinish Oct 5, 2023
955eb02
Merge remote-tracking branch 'origin/main' into id-equivalence-lib
mtreinish Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions qiskit/circuit/library/standard_gates/equivalence_library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
ECRGate,
ZGate,
CZGate,
IGate,
CCZGate,
XXPlusYYGate,
XXMinusYYGate,
Expand Down Expand Up @@ -170,6 +171,27 @@
def_r.append(U3Gate(theta, phi - pi / 2, -phi + pi / 2), [q[0]])
_sel.add_equivalence(RGate(theta, phi), def_r)

# IGate
q = QuantumRegister(1, "q")
def_id = QuantumCircuit(q)
def_id.append(UGate(0, 0, 0), [q[0]])
_sel.add_equivalence(IGate(), def_id)

q = QuantumRegister(1, "q")
def_id_rx = QuantumCircuit(q)
def_id_rx.append(RXGate(0), [q[0]])
_sel.add_equivalence(IGate(), def_id_rx)

q = QuantumRegister(1, "q")
def_id_ry = QuantumCircuit(q)
def_id_ry.append(RYGate(0), [q[0]])
_sel.add_equivalence(IGate(), def_id_ry)

q = QuantumRegister(1, "q")
def_id_rz = QuantumCircuit(q)
def_id_rz.append(RZGate(0), [q[0]])
_sel.add_equivalence(IGate(), def_id_rz)
Comment thread
kdk marked this conversation as resolved.

# RCCXGate
#
# ┌───────┐
Expand Down
13 changes: 5 additions & 8 deletions test/python/transpiler/test_basis_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,22 +928,19 @@ def test_cx_bell_to_ecr(self):
in_dag = circuit_to_dag(bell)
out_dag = BasisTranslator(std_eqlib, ["ecr", "u"]).run(in_dag)

# ┌────────────┐ ┌─────────────┐┌──────┐┌──────────┐
# q_0: ───┤ U(π/2,0,π) ├───┤ U(0,0,-π/2) ├┤0 ├┤ U(π,0,π) ├
# ┌──┴────────────┴──┐└─────────────┘│ Ecr │└──────────┘
# q_1: ┤ U(-π/2,-π/2,π/2) ├───────────────┤1 ├────────────
# └──────────────────┘ └──────┘

qr = QuantumRegister(2, "q")
expected = QuantumCircuit(2)
expected.u(pi / 2, 0, pi, qr[0])
expected.u(0, 0, -pi / 2, qr[0])
expected.u(-pi / 2, -pi / 2, pi / 2, qr[1])
expected.u(pi, 0, 0, qr[0])
expected.u(pi / 2, -pi / 2, pi / 2, qr[1])
expected.ecr(0, 1)
expected.u(pi, 0, pi, qr[0])
expected_dag = circuit_to_dag(expected)
Comment on lines 932 to 938
Copy link
Copy Markdown
Member

@jakelishman jakelishman Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question from the prior review! It got lost before - I must have forgotten to save the comment.

Do we know why this changes? We haven't added any rules that go to IGate, so I'd not have expected the basis-translation path to change.

Copy link
Copy Markdown
Member Author

@mtreinish mtreinish Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I'm not sure. I didn't really think to check. I just saw the output circuit was equivalent and updated the test. I'll do some debugging locally because the qpy tests are failing in a weird way now too so this is blocked on that anyway.


self.assertEqual(out_dag, expected_dag)
self.assertEqual(
Operator.from_circuit(bell), Operator.from_circuit(dag_to_circuit(out_dag))
)

def test_cx_bell_to_cp(self):
"""Verify we can translate a CX bell to CP,U."""
Expand Down