[WIP] allow distinction by parameter in InstructionDurations#6999
Closed
ajavadia wants to merge 9 commits into
Closed
[WIP] allow distinction by parameter in InstructionDurations#6999ajavadia wants to merge 9 commits into
ajavadia wants to merge 9 commits into
Conversation
Contributor
|
The broad strokes of this feel OK to me. The parsing logic does make one wish that we weren't receiving bare tuples from the backend to begin with... |
6537548 to
34b31c7
Compare
34b31c7 to
f6ed3f0
Compare
Pull Request Test Coverage Report for Build 1569649058
💛 - Coveralls |
f6ed3f0 to
3f9453d
Compare
Member
Author
|
superseded by #7321 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently the fields in InstructionDurations (name, qubits) are not enough to disambiguate in cases where say RX(pi/2) and RX(pi/4) are tuned up on the same qubits, with different durations. This adds a new field, params.