Skip to content

[WIP] allow distinction by parameter in InstructionDurations#6999

Closed
ajavadia wants to merge 9 commits into
Qiskit:mainfrom
ajavadia:inst-durations-params
Closed

[WIP] allow distinction by parameter in InstructionDurations#6999
ajavadia wants to merge 9 commits into
Qiskit:mainfrom
ajavadia:inst-durations-params

Conversation

@ajavadia
Copy link
Copy Markdown
Member

@ajavadia ajavadia commented Sep 9, 2021

currently the fields in InstructionDurations (name, qubits) are not enough to disambiguate in cases where say RX(pi/2) and RX(pi/4) are tuned up on the same qubits, with different durations. This adds a new field, params.

@ajavadia ajavadia requested a review from a team as a code owner September 9, 2021 16:06
@ajavadia ajavadia changed the title allow distinction by parameter in InstructionDurations [WIPallow distinction by parameter in InstructionDurations Sep 9, 2021
@ajavadia ajavadia changed the title [WIPallow distinction by parameter in InstructionDurations [WIP] allow distinction by parameter in InstructionDurations Sep 9, 2021
@ajavadia ajavadia marked this pull request as draft September 9, 2021 16:07
@ecpeterson
Copy link
Copy Markdown
Contributor

The broad strokes of this feel OK to me. The parsing logic does make one wish that we weren't receiving bare tuples from the backend to begin with...

@ajavadia ajavadia force-pushed the inst-durations-params branch from 6537548 to 34b31c7 Compare September 14, 2021 01:15
@ajavadia ajavadia force-pushed the inst-durations-params branch from 34b31c7 to f6ed3f0 Compare December 6, 2021 21:07
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 6, 2021

Pull Request Test Coverage Report for Build 1569649058

  • 45 of 67 (67.16%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 83.099%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 0 2 0.0%
qiskit/quantum_info/synthesis/xx_decompose/decomposer.py 1 5 20.0%
qiskit/transpiler/instruction_durations.py 39 55 70.91%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/instruction_durations.py 1 77.18%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 93.15%
Totals Coverage Status
Change from base Build 1561225116: -0.01%
Covered Lines: 51936
Relevant Lines: 62499

💛 - Coveralls

@ajavadia ajavadia force-pushed the inst-durations-params branch from f6ed3f0 to 3f9453d Compare December 12, 2021 14:06
@ajavadia
Copy link
Copy Markdown
Member Author

superseded by #7321

@ajavadia ajavadia closed this Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants