Skip to content

Blacken stragglers#6611

Merged
mergify[bot] merged 3 commits intoQiskit:mainfrom
levbishop:blacken_stragglers
Jun 21, 2021
Merged

Blacken stragglers#6611
mergify[bot] merged 3 commits intoQiskit:mainfrom
levbishop:blacken_stragglers

Conversation

@levbishop
Copy link
Copy Markdown
Member

@levbishop levbishop commented Jun 20, 2021

In #6361 we missed running black on the examples directory and on setup.py
This PR corrects that oversight and updates Makefile and tox.ini so that black and pylint are all run on the relevant files.
I think it would also be reasonable to run just black on the toplevel to avoid missing other future additions.

@levbishop levbishop added the type: qa Issues and PRs that relate to testing and code quality label Jun 20, 2021
@levbishop levbishop requested a review from mtreinish June 20, 2021 22:30
@levbishop levbishop requested a review from a team as a code owner June 20, 2021 22:30
@levbishop levbishop mentioned this pull request Jun 20, 2021
Closed
mtreinish
mtreinish reviewed Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One inline comment on the tox.ini. Also can you update the azure-pipelines.yml file too to include the extra paths.

Comment thread tox.ini Outdated
@levbishop
Copy link
Copy Markdown
Member Author

levbishop commented Jun 21, 2021

One inline comment on the tox.ini. Also can you update the azure-pipelines.yml file too to include the extra paths.

Done. VS Code flagged a lot of complaints about the azure-pipelines.yml not being schema-compliant, but I guess since things were working before, that is spurious?

@mtreinish
Copy link
Copy Markdown
Member

mtreinish commented Jun 21, 2021

One inline comment on the tox.ini. Also can you update the azure-pipelines.yml file too to include the extra paths.

Done. VS Code flagged a lot of complaints about the azure-pipelines.yml not being schema-compliant, but I guess since things were working before, that is spurious?

Yeah, I'm not sure what it's using for a schema. They may point to issues or deprecations in the config file. But it all works as expected so nothing it's reporting is fatal.

@mtreinish mtreinish added automerge Changelog: None Do not include in the GitHub Release changelog. labels Jun 21, 2021
@mergify mergify Bot merged commit 9e9ad8a into Qiskit:main Jun 21, 2021
@levbishop levbishop deleted the blacken_stragglers branch June 23, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees

No one assigned

Labels

Changelog: None Do not include in the GitHub Release changelog. type: qa Issues and PRs that relate to testing and code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@levbishop @mtreinish