Breaking up the version info python row in the qiskit_version_info magic#6590
Merged
Conversation
1ucian0
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
Member
Author
|
Because this PR is on top of #6589, putting |
mtreinish
reviewed
Jun 23, 2021
| if qver["qiskit-ibmq-provider"]: | ||
| packages.append(("IBM Q Provider", qver["qiskit-ibmq-provider"])) | ||
| for pkg in qver: | ||
| if qver[pkg]: |
Member
There was a problem hiding this comment.
This will exclude the metapackage if it's not installed, your earlier revisions left the metapackage line intact even if it was none. Did you want to leave it?
Member
There was a problem hiding this comment.
Oops, I did this on my phone and left a review on the wrong PR. I left the same comment in the parent PR: #6589 (comment)
Member
Author
|
removing |
mtreinish
approved these changes
Oct 1, 2021
mtreinish
added
automerge
Changelog: None
ElePT
pushed a commit
to ElePT/qiskit-algorithms
that referenced
this pull request
Jul 27, 2023
…gic (Qiskit/qiskit#6590) * qiskit_version_table with domain specific apps * breacking up the python line in the version_info magic * lint * code packages Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the python version row in when
%qiskit_version_infois disproportionally long. I suggest to braking it in 3.currently:
suggestion:
