Remove deprecated schemas and validation modules#6558
Merged
Conversation
This commit removes the deprecated schema support from the repo. This was deprecated in the 0.17.0 release and has been replaced by a dedicated repository for ibm's payload schemas: https://github.com/Qiskit/ibm-quantum-schemas This also removes jsonschema and fastjsonschema from the requirements list as they're no longer used which will improve the import performance.
mtreinish
added
on hold
Member
Author
|
0.18.0 has been released so removing the on hold because we can merge this now |
mtreinish
added
Changelog: Removed
kdk
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit removes the deprecated schema support from the repo. This
was deprecated in the 0.17.0 release and has been replaced by a
dedicated repository for ibm's payload schemas:
https://github.com/Qiskit/ibm-quantum-schemas
This also removes jsonschema and fastjsonschema from the requirements
list as they're no longer used which will improve the import
performance.
Details and comments
This is on hold until after we release 0.18.0. This can't be merged until July 1st, which is the end of the minimum deprecation period. I was just too eager to remove this code as it's been a multi-year effort to get the backend interface to a point where this could be done and decided to push it up as on hold PR so we can merge asap.