Make limit on waveform amplitude optional

[peendebak]

Summary

Remove limit of waveform amplitude.

Details and comments

Fixes #6012

[peendebak]

Rebase to main

[taalexander]

I believe the problem with failing linting is due to the recent incorporation of Black in #6361. It should be sufficient to run the black formatter over the files touched in this PR.

[nkanazawa1989]

Simple question: What happens if we send pulse with amplitude > 1. to our backend? Will it return 9999 error?

[eendebakpt]

Simple question: What happens if we send pulse with amplitude > 1. to our backend? Will it return 9999 error?

For the openpulse backend of https://qiskit.org/textbook/ch-quantum-hardware/calibrating-qubits-pulse.html there is an error:

IBMQJobFailureError: 'Unable to retrieve result for job 6096b1d254112347133f3ea6. Job has failed: Internal Error. Error code: 9372.'

[taalexander]

IBMQJobFailureError: 'Unable to retrieve result for job 6096b1d254112347133f3ea6. Job has failed: Internal Error. Error code: 9372.'

Thanks for highlighting this, I've created an internal ticket to add a more informative error in a future release.

[taalexander]

:py:attr:~some_property

[peendebak]

@taalexander Added release notes to the PR. Let me know whether we need to add something more.

[taalexander]

Thank you for additional changes, my only follow-up question is should we consider extending the limit_amplitude kwarg to the existing parametric pulse constructors?

[peendebak]

Thank you for additional changes, my only follow-up question is should we consider extending the limit_amplitude kwarg to the existing parametric pulse constructors?

I would suggest creating a new issue/PR for this since it will be backwards incompatible. (if we follow the same convention as for the other parametric pulses, e.g. limit_amplitude defaults to True)

[eendebakpt]

@taalexander I rebased to main. Let me know whether I should make any additional changes to the PR.

[taalexander]

Almost ready for merger.

[taalexander]

LGTM!

[taalexander]

Created a follow up issue #6544 for propagating limit_amplitude to parametric pulse constructors.