Add support on QuantumInstance/run_circuits for Backends that don't handle QasmQobj (backport #6299)#6343
Merged
Conversation
…andle QasmQobj (#6299) * Support BackendV1 * Add error mitigation logic. Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Fix run_circuits calls * add unit tests * Update qiskit/utils/run_circuits.py Add check for providers that don't support it. Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Add error mitigation test Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit a0ed7ff)
mergify
Bot
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
mtreinish
previously approved these changes
May 3, 2021
mtreinish
added
automerge
Changelog: Fixed
2 of the tests added in #6299 depend on the fake backends in qiskit.test.mock being strict BackendV1 backends (that reject qobj) and also having other aspects of the interface implemented (mainly run kwargs). However the change which updated the fake backends to use BackendV1 (#6286) is not backportable as it's an API change, so these tests are runnable in stable/0.17. This commit just removes these tests because even if we could get them running without #6286 we wouldn't be actually testing the v1 interface (which is their purpose).
mtreinish
previously approved these changes
May 3, 2021
manoelmarques
previously approved these changes
May 3, 2021
mtreinish
approved these changes
May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #6299 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/