Remove deprecation for pulse instruction parameter method#6277
Conversation
nkanazawa1989
requested review from
a team,
DanPuzzuoli,
lcapelluto and
taalexander
as code owners
|
Can you add a release note here? Probably an |
|
Thanks @mtreinish for catching this. Yes, deprecation node was added to 0.17 release. Reno is added. |
| for pulse_param in pulse_param_expr.parameters: | ||
| parameters.add(pulse_param) | ||
| if self.channel.is_parameterized(): | ||
| for ch_param in self.channel.parameters: |
There was a problem hiding this comment.
It seems that the tests need to be extended with parametrised channels: https://coveralls.io/builds/39061954/source?filename=qiskit%2Fpulse%2Finstructions%2Fplay.py#L105
1ucian0
left a comment
1ucian0
left a comment
There was a problem hiding this comment.
Not fully sure, but maybe a new test is needed to cover the added code.
|
Thanks @1ucian0 for catching this. Though these functionalities have been existing, it seems like we didn't have specific test for them. I added new test for play instruction paramters. |
1ucian0
added
the
Changelog: Removed
mtreinish
added
Changelog: Changed
6 participants
Summary
The parameter manager (in PR #5854) deprecated the instruction-level management of parameters to realize light-weight instruction object, i.e.
However this method is still needed for writing calibration code (thanks @eggerdj !). This PR removes deprecation warnings and add new logic to get the parameter set without initializing parameter table in the constructor.
Details and comments
No unittest is added by this PR, because there are tests for
.parametersmethod intest/python/pulse/test_parameters.py. These tests were not removed by #5854 for backward compatibility thus they should be still valid.