Skip to content

Speedup binding circuit parameters -- revisited #6112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 4 commits into from
Mar 31, 2021
Merged

Speedup binding circuit parameters -- revisited #6112

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76474e0
put call to unsorted params outside of loop
Cryoris Mar 30, 2021
ee2506e
Merge branch 'master' into speedup-circuit-params
Cryoris Mar 30, 2021
075049e
Merge branch 'master' into speedup-circuit-params
mtreinish Mar 30, 2021
7b7838f
Merge branch 'master' into speedup-circuit-params
Cryoris Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion qiskit/circuit/quantumcircuit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2016,10 +2016,11 @@ def assign_parameters(self, parameters, inplace=False,
if isinstance(parameters, dict):
# unroll the parameter dictionary (needed if e.g. it contains a ParameterVector)
unrolled_param_dict = self._unroll_param_dict(parameters)
unsorted_parameters = self._unsorted_parameters()

# check that all param_dict items are in the _parameter_table for this circuit
params_not_in_circuit = [param_key for param_key in unrolled_param_dict
if param_key not in self._unsorted_parameters()]
if param_key not in unsorted_parameters]
if len(params_not_in_circuit) > 0:
raise CircuitError('Cannot bind parameters ({}) not present in the circuit.'.format(
', '.join(map(str, params_not_in_circuit))))
Expand Down