no full scheduling of circuits with delay unless explicitly requested#6084
Merged
Conversation
ajavadia
force-pushed
the
fix-issue-5962
branch
3 times, most recently
from
8479569 to
34e7b0d
Compare
itoko
reviewed
Mar 26, 2021
itoko
reviewed
Mar 27, 2021
ajavadia
force-pushed
the
fix-issue-5962
branch
from
84de2a9 to
ce01b8e
Compare
ajavadia
added
the
Changelog: Fixed
itoko
reviewed
Mar 31, 2021
lcapelluto
reviewed
Mar 31, 2021
| information, or explicitly supply ``instruction_durations`` as an argument | ||
| to the transpiler. | ||
| instructions, the units will be converted to dt if the value of dt | ||
| (sample time) is known to the transpile (either via explicit dt arg or via |
Contributor
There was a problem hiding this comment.
Suggested change
| (sample time) is known to the transpile (either via explicit dt arg or via | |
| (sample time) is known to the transpiler (either via explicit dt arg or via |
Member
There was a problem hiding this comment.
I've made mental note of this, I'll just fix it in #6075
lcapelluto
approved these changes
Mar 31, 2021
Contributor
lcapelluto
left a comment
lcapelluto
left a comment
There was a problem hiding this comment.
One typo in release notes. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #5972:
TimeUnitConversionto make units of duration consistent (either all dt if dt is known, or all s). This pass is a small modification on the already-existingTimeUnitAnalysis.durationmetadata and all units are consistent. So the schedulers can focus on the logic of scheduling only. (Hence theALAPScheduleandASPASchedulenowrequiretheTimeUnitConversionto meet their precondition).Fixes #5962