Change ParameterExpression __eq__ to sympy equals()#5760
Merged
mergify[bot] merged 11 commits intoQiskit:masterfrom Feb 2, 2021
Merged
Change ParameterExpression __eq__ to sympy equals()#5760mergify[bot] merged 11 commits intoQiskit:masterfrom
mergify[bot] merged 11 commits intoQiskit:masterfrom
Conversation
kdk
added
the
Changelog: Changed
kdk
approved these changes
Feb 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5611
Details and comments
This PR changes the ParameterExpression
__eq__from using the sympysreprmethod to using theequalsmethod. Thesreprmethod required an exact match of the expressions and would not handle a float equal to an int, for example. Theequalsmethod simplifies both expressions and will do normal float/int equality.