Fix typo adding non-gates to _collect_1q_runs() output#5740
Merged
mergify[bot] merged 1 commit intoJan 28, 2021
Conversation
mtreinish
added
priority: high
Changelog: Fixed
mtreinish
force-pushed
the
fix-regression-collect_1q_runs
branch
from
f711f00 to
44f78a9
Compare
This commit fixes a bug introduced in the backport PR Qiskit#5655. On the current master branch the bugfix that was being backported relies on a feature in newer versions of retworkx. Since we can't bump the minimum retworkx version required on a stable branch that functionality was rewritten in the dagcircuit class directly. However, that implementation included a typo which is causing non-gates and atomic instructions to be included in collected runs which is not correct behavior and causes errors to be raised. This commit corrects the bug in the backport and adds a test to ensure the regression is not present. This is a direct commit to the stable branch and not a backport since this bug is not present on master and was only introduced through a bad backport. Fixes Qiskit#5736
mtreinish
force-pushed
the
fix-regression-collect_1q_runs
branch
from
44f78a9 to
7d1bf56
Compare
Member
Author
|
Once this merges I will push a PR to prepare the 0.16.3 release |
kdk
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes a bug introduced in the backport PR #5655. On the
current master branch the bugfix that was being backported relies on a
feature in newer versions of retworkx. Since we can't bump the minimum
retworkx version required on a stable branch that functionality was
rewritten in the dagcircuit class directly. However, that implementation
included a typo which is causing non-gates and atomic instructions to be
included in collected runs which is not correct behavior and causes
errors to be raised. This commit corrects the bug in the backport and
adds a test to ensure the regression is not present.
This is a direct commit to the stable branch and not a backport since
this bug is not present on master and was only introduced through a bad
backport.
Details and comments
Fixes #5736