Add unroll step to level2 passmanager optimization loop#5671
Merged
Conversation
This commit adds the basis translation step to the level 2 preset passmanager's optimization loop. The level 2 optimization loop runs the commutative cancellation pass which use Rx and U1 gates as part of it's optimization step which may not be in the target basis gates. This can result in a gate outside of the target basis ended up in the output. To avoid this in a general manner we need to rely on the basis translation step because we can't write a pass to do the simplified rotation in a manner compatible with any basis (especially since the target basis could be using custom gates). Fixes Qiskit#5644
mtreinish
added
stable backport potential
ajavadia
approved these changes
Jan 21, 2021
mergify Bot
pushed a commit
that referenced
this pull request
Jan 22, 2021
This commit adds the basis translation step to the level 2 preset passmanager's optimization loop. The level 2 optimization loop runs the commutative cancellation pass which use Rx and U1 gates as part of it's optimization step which may not be in the target basis gates. This can result in a gate outside of the target basis ended up in the output. To avoid this in a general manner we need to rely on the basis translation step because we can't write a pass to do the simplified rotation in a manner compatible with any basis (especially since the target basis could be using custom gates). Fixes #5644 (cherry picked from commit 25eb58a)
mergify Bot
added a commit
that referenced
this pull request
Jan 22, 2021
This commit adds the basis translation step to the level 2 preset passmanager's optimization loop. The level 2 optimization loop runs the commutative cancellation pass which use Rx and U1 gates as part of it's optimization step which may not be in the target basis gates. This can result in a gate outside of the target basis ended up in the output. To avoid this in a general manner we need to rely on the basis translation step because we can't write a pass to do the simplified rotation in a manner compatible with any basis (especially since the target basis could be using custom gates). Fixes #5644 (cherry picked from commit 25eb58a) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds the basis translation step to the level 2 preset
passmanager's optimization loop. The level 2 optimization loop runs the
commutative cancellation pass which use Rx and U1 gates as part of it's
optimization step which may not be in the target basis gates. This can
result in a gate outside of the target basis ended up in the output. To
avoid this in a general manner we need to rely on the basis translation
step because we can't write a pass to do the simplified rotation in a
manner compatible with any basis (especially since the target basis
could be using custom gates).
Details and comments
Fixes #5644