More efficient C3X implementation#5668
Merged
Merged
Conversation
ajavadia
added
the
stable backport potential
ajavadia
approved these changes
Jan 21, 2021
mergify Bot
pushed a commit
that referenced
this pull request
Jan 21, 2021
* update c3x decomp * fix call with "angle" argument * rename to C3SX and fix tests * fix typo * add reno (cherry picked from commit b9c943b) # Conflicts: # qiskit/circuit/library/standard_gates/x.py
mergify Bot
added a commit
that referenced
this pull request
Jan 25, 2021
* More efficient C3X implementation (#5668) * update c3x decomp * fix call with "angle" argument * rename to C3SX and fix tests * fix typo * add reno (cherry picked from commit b9c943b) # Conflicts: # qiskit/circuit/library/standard_gates/x.py * fix merge conflicts * fix test Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
kdk
added
the
Changelog: Added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use a more efficient decomposition for C3X that only uses 14 CX, proposed by @dmitrimaslov.
Details and comments
Also deprecates the
angleargument and adds an explicitC3SXgate for the three times controlled SX gate, as already started in #4378.