Cleanup unneeded Register use in standard library definitions.#5529
Closed
kdk wants to merge 3 commits intoQiskit:mainfrom
Closed
Cleanup unneeded Register use in standard library definitions.#5529kdk wants to merge 3 commits intoQiskit:mainfrom
kdk wants to merge 3 commits intoQiskit:mainfrom
Conversation
kdk
requested review from
a team,
DanPuzzuoli,
chriseclectic,
eggerdj,
lcapelluto,
manoelmarques,
nkanazawa1989,
nonhermitian,
taalexander and
woodsp-ibm
as code owners
kdk
force-pushed
the
quantumcircuit-optional-registers-library-cleanup
branch
2 times, most recently
from
4a96967 to
c258e92
Compare
kdk
force-pushed
the
quantumcircuit-optional-registers-library-cleanup
branch
from
c258e92 to
22edfe2
Compare
Member
|
#5519 merged, removing |
kdk
force-pushed
the
quantumcircuit-optional-registers-library-cleanup
branch
from
22edfe2 to
2add781
Compare
Member
|
What's the status of this PR, now that #6496 (deprecating implicit register creation in Edit: after a bit more reading, I realise that implicit register creation is deprecated, but implicit qubit creation isn't. So |
Member
|
I'm going to close this as stale as it hasn't been updated in 2 yrs and has extensive merge conflicts. If this is still needed or there is ongoing work on it please feel free to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following #5519 , removes unneeded
QuantumRegister(N, 'q')s from standard library.Details and comments
on-hold until #5519 .Commits in this PR (without #5519, #5515, #5504, #5498 and #5486): https://github.com/Qiskit/qiskit-terra/pull/5529/files/e7eab4a76aa311b4c7b22cbca5d5ce9b86ba71c4..13c4e0c8856d85f3ecf405e75d56cde263b9a74f