Expand test_examples skip on macOS #5465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test skip we had in place on test_examples was for macOS with python 3.8. This was because when we first enabled python 3.8 support, the change to use spawn as the default macOS multiprocessing launch method was causing the tests to fail with the way the examples are written (without using '__name__ == "__main__"'). When we added Python 3.9 support in Qiskit#5189 these tests were run because skip was only on 3.8. While the tests appear to work most of the time (and passed ci in Qiskit#5189) as these jobs have been running in CI the test_examples module has occasionally been segfaulting when running the example, which has resulted in a failure rate of roughly 8-10%. This commit expands the macOS skip on the tests to be >= 3.8 so we avoid these failure conditions.
kdk
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test skip we had in place on test_examples was for macOS with python
3.8. This was because when we first enabled python 3.8 support, the
change to use spawn as the default macOS multiprocessing launch method
was causing the tests to fail with the way the examples are written
(without using
__name__ == "__main__"). When we added Python 3.9support in #5189 these tests were run because skip was only on 3.8.
While the tests appear to work most of the time (and passed ci in #5189)
as these jobs have been running in CI the test_examples module has
occasionally been segfaulting when running the example, which has
resulted in a failure rate of roughly 8-10%. This commit expands the
macOS skip on the tests to be >= 3.8 so we avoid these failure
conditions.
Details and comments