Honor initial_layout when coupling map is None#5346
Merged
mergify[bot] merged 17 commits intoQiskit:masterfrom Nov 26, 2020
Merged
Honor initial_layout when coupling map is None#5346mergify[bot] merged 17 commits intoQiskit:masterfrom
mergify[bot] merged 17 commits intoQiskit:masterfrom
Conversation
ajavadia
reviewed
Nov 9, 2020
Comment on lines
+197
to
+198
| transpiled = transpile(qc, initial_layout=[4, 2], optimization_level=level, | ||
| callback=self.callback) |
Member
There was a problem hiding this comment.
so what does transpiled look like here? is it a 2 qubit circuit or a 5 qubit circuit?
Member
There was a problem hiding this comment.
I think taking the max of the initial layout makes sense for these situations.
Member
|
can you add a release note and a note to the |
Member
Author
|
Release note added in 0a55275 |
kdk
approved these changes
Nov 25, 2020
kdk
added
Changelog: Fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5345
This PR embeds the layout when
initial_layoutis provided, even whencoupling_map=None.Additionally, it allows
coupling_map=NoneinFullAncillaAllocationandCheckMap