Move wrapper load_qasm_* methods to a submodule#533
Merged
atilag merged 6 commits intoJun 11, 2018
Merged
Conversation
ajavadia
previously approved these changes
Jun 6, 2018
Contributor
Author
|
Per a discussion with @atilag we agreed on moving these methods again to wrapper but to a different submodule so |
366adbd to
c0890cb
Compare
atilag
previously approved these changes
Jun 7, 2018
c0890cb to
7c473a1
Compare
Member
|
For the new files, can you adjust the license header so it follows the format recently introduced by #550 ? |
7c473a1 to
b85e5de
Compare
atilag
previously approved these changes
Jun 11, 2018
Member
|
@delapuente can you update CHANGELOG.rst accordingly? :) |
…asm-to-quantum-circuit-static-methods
load_qasm_* methods to a submodule
load_qasm_* methods to a submoduleload_qasm_* methods to a submodule
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
It was intended that
load_qasm_stringandload_qasm_filecall static constructors in theQuantumCircuitinstead of being implemented atwrappermodule-level.How Has This Been Tested?
Passing the same test suite without alterations.
Checklist: