Deprecate Python 3.6 support #5301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deprecates Python 3.6 support. During the deprecation window we will continue to fully support Python 3.6 and test it in CI, but it will emit a warning that we will be removing support for 3.6 in the future to inform users to upgrade to Python 3.7 or newer. The exact removal date hasn't been decided yet but it will likely be before the upstream Python EoL date in Decemeber 2021. [1] [1] https://devguide.python.org/#branchstatus
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Oct 28, 2020
The Python 3.6 deprecation is being handled separately in Qiskit#5301 to decouple it from adding python 3.9 support. This commit removes the 3.6 deprecation accordingly.
Member
|
EoL date: 2021-12-23 Can we merge this one now? |
kdk
approved these changes
Dec 1, 2020
kdk
added
the
Changelog: Deprecated
mergify bot
added a commit
that referenced
this pull request
Dec 2, 2020
* Add support for Python 3.9 Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-terra. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9 and build python 3.9 wheels. * Also deprecate 3.6 * Use latest nodes for CI * Remove Python 3.6 deprecation The Python 3.6 deprecation is being handled separately in #5301 to decouple it from adding python 3.9 support. This commit removes the 3.6 deprecation accordingly. * Bump cibuildwheel version to the latest release * Remove unused assertNoLogs method The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (not just terra). Since the implementation is not sound and nothing uses it this commit just removes the class and method. * Fix lint * Remove aer from macOS and windows jobs * Remove IBMQ provider from ci jobs The ibmq provider is not used by anything in CI anymore. It was an historical artifact when some of the visualization and jupyter tests required it. This is no longer true. However, installing the ibmq provider in the linux 3.9 job is blocking CI because of an unrelated requests library issue with urllib3. To resolve this, this commit just removes the unecessary install. * Add back ibmqprovider to tutorials job, it's needed for aqua tutorials * Fix jupyter test skip * Update test/python/tools/jupyter/test_notebooks.py Co-authored-by: Christian Clauss <cclauss@me.com> * Fix lint * Add back pbars macOS test skip Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Jan 19, 2021
* Add support for Python 3.9 Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-terra. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9 and build python 3.9 wheels. * Also deprecate 3.6 * Use latest nodes for CI * Remove Python 3.6 deprecation The Python 3.6 deprecation is being handled separately in #5301 to decouple it from adding python 3.9 support. This commit removes the 3.6 deprecation accordingly. * Bump cibuildwheel version to the latest release * Remove unused assertNoLogs method The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (not just terra). Since the implementation is not sound and nothing uses it this commit just removes the class and method. * Fix lint * Remove aer from macOS and windows jobs * Remove IBMQ provider from ci jobs The ibmq provider is not used by anything in CI anymore. It was an historical artifact when some of the visualization and jupyter tests required it. This is no longer true. However, installing the ibmq provider in the linux 3.9 job is blocking CI because of an unrelated requests library issue with urllib3. To resolve this, this commit just removes the unecessary install. * Add back ibmqprovider to tutorials job, it's needed for aqua tutorials * Fix jupyter test skip * Update test/python/tools/jupyter/test_notebooks.py Co-authored-by: Christian Clauss <cclauss@me.com> * Fix lint * Add back pbars macOS test skip Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 200d739)
mergify bot
added a commit
that referenced
this pull request
Jan 21, 2021
* Add support for Python 3.9 Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-terra. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9 and build python 3.9 wheels. * Also deprecate 3.6 * Use latest nodes for CI * Remove Python 3.6 deprecation The Python 3.6 deprecation is being handled separately in #5301 to decouple it from adding python 3.9 support. This commit removes the 3.6 deprecation accordingly. * Bump cibuildwheel version to the latest release * Remove unused assertNoLogs method The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (not just terra). Since the implementation is not sound and nothing uses it this commit just removes the class and method. * Fix lint * Remove aer from macOS and windows jobs * Remove IBMQ provider from ci jobs The ibmq provider is not used by anything in CI anymore. It was an historical artifact when some of the visualization and jupyter tests required it. This is no longer true. However, installing the ibmq provider in the linux 3.9 job is blocking CI because of an unrelated requests library issue with urllib3. To resolve this, this commit just removes the unecessary install. * Add back ibmqprovider to tutorials job, it's needed for aqua tutorials * Fix jupyter test skip * Update test/python/tools/jupyter/test_notebooks.py Co-authored-by: Christian Clauss <cclauss@me.com> * Fix lint * Add back pbars macOS test skip Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 200d739) Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit deprecates Python 3.6 support. During the deprecation window
we will continue to fully support Python 3.6 and test it in CI, but it will
emit a warning that we will be removing support for 3.6 in the future to
inform users to upgrade to Python 3.7 or newer. The exact removal date
hasn't been decided yet but it will likely be before the upstream Python
EoL date in Decemeber 2021. [1]
Details and comments
[1] https://devguide.python.org/#branchstatus