Fix issue 4959 modifying the tests from pi to π

[alejomonbar]

Summary

Fixes #4959

Details and comments

The test cases were comparing a string which includes "pi" and I modify it to "π"

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ alejomonbar
❌ Jhon Montanez

---

Jhon Montanez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[1ucian0]

Jhon Montanez needs to sign CLA too

[alejomonbar]

Jhon Montanez needs to sign CLA too

I'm Jhon Montanez. I didn't update my git hub email account in the terminal and I pull requested and I don't know how to solve it now :(!

[1ucian0]

Maybe you want to remove it as co-author from the history?

[alejomonbar]

Maybe you want to remove it as co-author from the history?

Yes, I'm trying to do that. But, I don't find the correct way to do that. Any advice?

[1ucian0]

I think if you squash you will be able to remove the co-author.

[1ucian0]

The problem the current solution is that π might be out of the charset for self.enconding an pi should be used in that case. Have a look to #4959 (comment)

[alejomonbar]

The problem the current solution is that π might be out of the charset for self.enconding an pi should be used in that case. Have a look to #4959 (comment)

I tried to encode and decode with both encodings utf8 and cp437 and both are able to manage π. Do you want me to try another encode?

[1ucian0]

Probably you are right and most of the charsets that have ╞ also have π. I was thinking that maybe obscure code pages like 866 might be a problem.. but probably they are problematic already...

[1ucian0]

?

[alejomonbar]

?

Sorry, @1ucian0, I closed this pull request and I create a new one. I couldn't figure out how to eliminate those commits with Jhon Montanez. The new pull request is this #5218