Remove Sympy simulators for moving to new repository#514
Merged
Conversation
jaygambetta
previously approved these changes
Jun 1, 2018
8 tasks
Member
|
Thanks for the thorough removal of the sympy simulators, @yaelbh ! I am merging this PR already after discussion on yesterday's meeting, looking forward to the simulators finding a new home in the new repo soon 🎉 |
diego-plan9
approved these changes
Jun 6, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Removed files that were copied to the new repository * Completely removed all mentions of Sympy simulators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing Issue #425, I created a new repository for Sympy simulators. In that repository, I opened a pull request, parallel to this one:
https://github.com/QISKit/qiskit-core-backend-module-sympy/pull/1
Now back to the qiskit-sdk-py repository, this pull request removes Sympy simulators, while making sure that all thet remains in qiskit-sdk-py works properly.
Issue #425 contains more detailed information about what's planned both here and in the new repository.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: