Remove deprecated commands/Commands/FrameChange/PersistentValue#4671
Remove deprecated commands/Commands/FrameChange/PersistentValue#4671mergify[bot] merged 13 commits intoQiskit:masterfrom
Conversation
lcapelluto
requested review from
a team,
DanPuzzuoli,
eggerdj,
maddy-tod,
nkanazawa1989 and
nonhermitian
as code owners
lcapelluto
force-pushed
the
remove-deprecated-commands
branch
from
eeec6d2 to
fbb641f
Compare
taalexander
left a comment
taalexander
left a comment
There was a problem hiding this comment.
With a reno this should be good to go.
|
I don't know what's going on. Somehow the docs are taking over an hour to build, so the build gets cancelled. Not sure what would cause it to hang like that. |
This is something I noticed yesterday (or earlier this week the days have been blending together for me lately), it looks like since we enabled parallel sphinx builds in ci with #4477 we've triggered a bug in jupyter execute (which I still need to reproduce and report upstream). Basically it looks like when a jupyter cell exits with an error/exception the parallel worker stops without reporting it's done to the parent process, so the sphinx build sits waiting for a failed worker process to finish forever. Well until we hit the azure pipeline timeout and the job gets cancelled. I'd suggest trying the docs build locally (probably removing My guess based on this PR is that there is a jupyter execute somewhere in the docs or release notes that's using the deprecated things being removed here that's crashing the docs builds. |
|
@mtreinish Is using GitHub Actions for docs build a good option here? |
That doesn't really solve the problem here, it would actually make it worse since the timeout is 6 hours instead of 1 hour so we'd be eating up a job for much longer. The parallel docs jobs for terra typically take about 12-13 min which is far from being in danger of hitting a timeout. The only reason we're having an issue here now is because of a bug in the jupyter-sphinx extension with parallel execution. We could turn off parallel execution and docs builds would go back up to 15-20min running serially but we'd avoid the bug where a failure in |
lcapelluto
force-pushed
the
remove-deprecated-commands
branch
from
e215de0 to
5db181e
Compare
taalexander
left a comment
taalexander
left a comment
There was a problem hiding this comment.
If we can get passing tests, I believe this is good to go 😄
| # new | ||
| Instruction(args, channel) | ||
|
|
||
| :: |
There was a problem hiding this comment.
This seems odd, but maybe I don't know enough about what it is doing.
There was a problem hiding this comment.
I wanted to make two separate literal blocks
Follow-up to Qiskit#4671. Removes any remaining "pv"/PersistentValue references in examples/tests. Leaving entry in qiskit/schemas/qobj_schema.json for validation purposes.
Follow-up to #4671. Removes any remaining "pv"/PersistentValue references in examples/tests. Leaving entry in qiskit/schemas/qobj_schema.json for validation purposes. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
4 participants
Summary
Remove deprecated commands! 🙌
Details and comments