change Instruction.definition from List[Tuple] to QuantumCircuit#4622
Merged
Conversation
some multi-qubit controlled gate tests are still failing.
ajavadia
reviewed
Jun 30, 2020
ewinston
changed the title
ajavadia
reviewed
Jul 3, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…kit#4622) * definition changed to circuit some multi-qubit controlled gate tests are still failing. * resolve c_if register conversion * revert removal of _define in standard gates * linting * resolve qreg bug in transpiler * simplify unroller passes a bit * linting * resolve doc forward ref * linting * linting * linting Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to change the type of Instruction.definition from list of tuples to QuantumCircuit.
Summary
The change here was mostly to replace
gate.definitionwithgate.definition.dataor assigning gate.definition directly to a quantum circuit if that made more sense.Details and comments