Matplotlib drawer update to show 2 qubit params#4566
Closed
sar49 wants to merge 30 commits intoQiskit:masterfrom
Closed
Matplotlib drawer update to show 2 qubit params#4566sar49 wants to merge 30 commits intoQiskit:masterfrom
sar49 wants to merge 30 commits intoQiskit:masterfrom
Conversation
…over a error in text drawer
…b's barrier test case file
sar49
changed the title
Member
|
Considering adding a "test" following this style #4544 |
Contributor
Author
|
Yes, I think all of the circuit tests that are done by the tester should be transferred over to the binder test like in #4544. It is much more accurate and easier to see small scaling errors and whatnot |
Member
|
The issue fixed by this PR is already solved. If you consider this PR is also covering other aspects that are not in current master, please reopen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4563
Details and comments
The two qubit gate that was referenced did not have a subtext parameter which I just added to the function call when the gate was drawn. The positioning of the subtext was by default a bit too high so I lowered it down. By default the y position for the main text and subtext was .5 * height and .3 * height respectively which I brought down to .4 * height and .3 * height. Also, I added gates rxx, rzx, and ryy to qcstyle so that they could be displayed with first letter capitalized and the rest subscripted.