Skip to content

Changed default color in mpl drawer from white to purple#4519

Closed
enavarro51 wants to merge 5 commits intoQiskit:masterfrom
enavarro51:fixissue4496branch
Closed

Changed default color in mpl drawer from white to purple#4519
enavarro51 wants to merge 5 commits intoQiskit:masterfrom
enavarro51:fixissue4496branch

Conversation

@enavarro51
Copy link
Contributor

Summary

Fixed #4496

Details and comments

Changed default gate color in qcstyle from white to purple.

@enavarro51 enavarro51 requested review from a team, maddy-tod and nonhermitian as code owners May 28, 2020 23:19
@1ucian0
Copy link
Member

1ucian0 commented Jun 11, 2020

MPL circuit drawer issues are piling up, since we dont have a good way to track changes on it. I'm putting this PR on hold (meaning "do not merge yet") until #4544 (or a similar solution) gets in.

@1ucian0 1ucian0 added the on hold Can not fix yet label Jun 11, 2020
@1ucian0
Copy link
Member

1ucian0 commented Jun 22, 2020

#4544 is merged... Let's add a test with the new method!

I will try helping, but fill free to do it yourself and ask me if any question.

@1ucian0 1ucian0 removed the on hold Can not fix yet label Jun 22, 2020
@1ucian0 1ucian0 marked this pull request as draft June 22, 2020 18:55
@1ucian0
Copy link
Member

1ucian0 commented Jun 22, 2020

@1ucian0 1ucian0 marked this pull request as ready for review June 22, 2020 20:14
@1ucian0
Copy link
Member

1ucian0 commented Jul 7, 2020

This one was covered by PR #4616.

@1ucian0 1ucian0 closed this Jul 7, 2020
@enavarro51 enavarro51 deleted the fixissue4496branch branch February 24, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic Gates have no color in MPL circuit drawer

2 participants