Remove almost-one-year-old deprecated methods (warning was inserted in #2683)#4498
Merged
Conversation
1ucian0
added
the
Changelog: Removed
mtreinish
previously requested changes
May 28, 2020
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
This looks fine to me, those functions were deprecated in 0.9 which was released in Aug 2019. It's definitely had a full deprecation window at this point. The only thing missing here is an upgrade release note about the removal after that's added it should be good to merge
Member
Author
Added in a33f1d2 |
ajavadia
approved these changes
Jun 18, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…Qiskit#2683) (Qiskit#4498) * remove methods deprecated by Qiskit#2683 * test_generate_tokens * unused import * release note Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2683, we deprecated some methods. That was almost a year ago. Time to remove them.